From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CEDADC83F2C for ; Mon, 4 Sep 2023 16:39:16 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qdCbB-00041x-CL; Mon, 04 Sep 2023 12:38:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdCb8-00040m-HW for qemu-devel@nongnu.org; Mon, 04 Sep 2023 12:38:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdCb2-000502-VR for qemu-devel@nongnu.org; Mon, 04 Sep 2023 12:38:46 -0400 Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-363-n2ioqOH0PF-NBkmIyU_qkQ-1; Mon, 04 Sep 2023 12:38:35 -0400 X-MC-Unique: n2ioqOH0PF-NBkmIyU_qkQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 44A721C05AD0; Mon, 4 Sep 2023 16:38:34 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.145]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 583A740C206F; Mon, 4 Sep 2023 16:38:31 +0000 (UTC) Date: Mon, 4 Sep 2023 17:38:29 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: William Tsai Cc: qemu-devel@nongnu.org, Kevin Wolf , Hanna Reitz , Eric Blake , Vladimir Sementsov-Ogievskiy , Peter Lieven , Fam Zheng , "Richard W.M. Jones" , Markus Armbruster , Michael Roth , Paolo Bonzini , Eduardo Habkost , Richard Henderson , David Hildenbrand , Ilya Leoshkevich , Thomas Huth , Peter Maydell , Laurent Vivier , "open list:Block layer core" , "open list:S390 TCG CPUs" , "open list:ARM TCG CPUs" Subject: Re: [PATCH v2] qdict: Preserve order for iterating qdict elements Message-ID: References: <20230902094041.8626-1-williamtsai1111@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230902094041.8626-1-williamtsai1111@gmail.com> User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, T_SPF_HELO_TEMPERROR=0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Sat, Sep 02, 2023 at 05:40:40PM +0800, William Tsai wrote: > Changing the structure of qdict so that it can preserve order when > iterating qdict. This will fix array_properties as it relies on `len-` > prefixed argument to be set first. > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1090 > Signed-off-by: William Tsai This is a variation of what Markus illustrated a year ago https://lists.gnu.org/archive/html/qemu-devel/2022-07/msg00758.html I wasn't a particular fan of that approach at the time. I've made an alternative proposal here which avoids the broader impact of this QDict change: https://lists.gnu.org/archive/html/qemu-devel/2023-09/msg00652.html With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|