From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EAC8DC83F3E for ; Tue, 5 Sep 2023 12:43:13 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qdVOX-0006cQ-GO; Tue, 05 Sep 2023 08:43:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdVOV-0006cB-Iv for qemu-devel@nongnu.org; Tue, 05 Sep 2023 08:42:59 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdVOS-0004Pd-Sz for qemu-devel@nongnu.org; Tue, 05 Sep 2023 08:42:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1693917774; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=syV/FwlhZ8GavKAKNN92BvjVA6CcqF96Xwd87qlPgEg=; b=hlXTcPlK2DyF+WEt/OLaEd685z6ZaCUqU27DQ8yyVtwl66GVstbYHcpV/0kwpDgJC00XJJ P2+k+iJ3q368ePU/9RUYeeD1bCVdzL7UdpyJX0q89eIJHzN1CmO+kVG2pzBlCvm5lZeboS boqPEMzBhN4YRU3WrvMmTTErzJbqenE= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-246-zB1Gy92ANlStTfI2aPY_Vg-1; Tue, 05 Sep 2023 08:42:50 -0400 X-MC-Unique: zB1Gy92ANlStTfI2aPY_Vg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2D7D81C0782D; Tue, 5 Sep 2023 12:42:50 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.134]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0A0A946F523; Tue, 5 Sep 2023 12:42:48 +0000 (UTC) Date: Tue, 5 Sep 2023 13:42:46 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Mads Ynddal Cc: qemu-devel@nongnu.org, John Snow , Stefan Hajnoczi , Cleber Rosa , Mads Ynddal Subject: Re: [PATCH v4 12/14] simpletrace: added simplified Analyzer2 class Message-ID: References: <20230823085429.20519-1-mads@ynddal.dk> <20230823085429.20519-13-mads@ynddal.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230823085429.20519-13-mads@ynddal.dk> User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, Aug 23, 2023 at 10:54:27AM +0200, Mads Ynddal wrote: > From: Mads Ynddal > > By moving the dynamic argument construction to keyword-arguments, > we can remove all of the specialized handling, and streamline it. > If a tracing method wants to access these, they can define the > kwargs, or ignore it be placing `**kwargs` at the end of the > function's arguments list. > > Added deprecation warning to Analyzer class to make users aware > of the Analyzer2 class. No removal date is planned. AFAIK, we don't consider simpletrace.py python code to be a supported public API, just a command line tool. IOW, we can change the python code at will, as long as the command line doesn't alter its behaviour. Thus I don't see a need to add new classes, just change the existing ones. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|