qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: Mattias Nissler <mnissler@rivosinc.com>
Cc: "Markus Armbruster" <armbru@redhat.com>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	qemu-devel@nongnu.org, john.levon@nutanix.com,
	"Jagannathan Raman" <jag.raman@oracle.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"David Hildenbrand" <david@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Elena Ufimtseva" <elena.ufimtseva@oracle.com>
Subject: Re: [PATCH v2 1/4] softmmu: Support concurrent bounce buffers
Date: Tue, 5 Sep 2023 09:45:51 -0400	[thread overview]
Message-ID: <ZPcxD+lqtt8PFwCl@x1n> (raw)
In-Reply-To: <CAGNS4TaEL1CapL3NoM4XYVMLOH-heOs=2WHMLHNEz072fcxNfw@mail.gmail.com>

On Tue, Sep 05, 2023 at 09:38:39AM +0200, Mattias Nissler wrote:
> It would be nice to use a property on the device that originates the
> DMA operation to configure this. However, I don't see how to do this
> in a reasonable way without bigger changes: A typical call path is
> pci_dma_map -> dma_memory_map -> address_space_map. While pci_dma_map
> has a PCIDevice*, address_space_map only receives the AddressSpace*.
> So, we'd probably have to pass through a new QObject parameter to
> address_space_map that indicates the originator and pass that through?
> Or is there a better alternative to supply context information to
> address_space map? Let me know if any of these approaches sound
> appropriate and I'll be happy to explore them further.

Should be possible to do. The pci address space is not shared but
per-device by default (even if there is no vIOMMU intervention).  See
do_pci_register_device():

    address_space_init(&pci_dev->bus_master_as,
                       &pci_dev->bus_master_container_region, pci_dev->name);

Thanks,

-- 
Peter Xu



  reply	other threads:[~2023-09-05 13:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-23  9:29 [PATCH v2 0/4] Support message-based DMA in vfio-user server Mattias Nissler
2023-08-23  9:29 ` [PATCH v2 1/4] softmmu: Support concurrent bounce buffers Mattias Nissler
2023-08-23 17:34   ` Peter Xu
2023-08-23 20:08     ` Mattias Nissler
2023-08-23 20:54       ` Peter Xu
2023-08-24  6:58         ` Mattias Nissler
2023-08-24 13:32         ` Stefan Hajnoczi
2023-09-01 13:41           ` Markus Armbruster
2023-09-05  7:38             ` Mattias Nissler
2023-09-05 13:45               ` Peter Xu [this message]
2023-09-07 12:37                 ` Mattias Nissler
2023-08-23  9:29 ` [PATCH v2 2/4] Update subprojects/libvfio-user Mattias Nissler
2023-08-23  9:29 ` [PATCH v2 3/4] vfio-user: Message-based DMA support Mattias Nissler
2023-08-23  9:29 ` [PATCH v2 4/4] vfio-user: Fix config space access byte order Mattias Nissler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZPcxD+lqtt8PFwCl@x1n \
    --to=peterx@redhat.com \
    --cc=armbru@redhat.com \
    --cc=david@redhat.com \
    --cc=elena.ufimtseva@oracle.com \
    --cc=jag.raman@oracle.com \
    --cc=john.levon@nutanix.com \
    --cc=mnissler@rivosinc.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).