From: Kevin Wolf <kwolf@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
qemu-devel@nongnu.org, "William Tsai" <williamtsai1111@gmail.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Eduardo Habkost" <eduardo@habkost.net>
Subject: Re: [PATCH 0/1] qom: fix setting of qdev array properties
Date: Thu, 7 Sep 2023 14:59:49 +0200 [thread overview]
Message-ID: <ZPnJRVnC13X25orb@redhat.com> (raw)
In-Reply-To: <87edja9vkr.fsf@pond.sub.org>
Am 07.09.2023 um 11:33 hat Markus Armbruster geschrieben:
> Kevin Wolf <kwolf@redhat.com> writes:
> > Am 04.09.2023 um 18:25 hat Daniel P. Berrangé geschrieben:
> >> I still think for user creatable devices we'd be better off just
> >> mandating the use of JSON syntax for -device and thus leveraging
> >> the native JSON array type. This patch was the quick fix for the
> >> existing array property syntax though.
> >
> > I agree, let's not apply this one. It puts another ugly hack in the
> > common QOM code path just to bring back the old ugly hack in qdev.
>
> Since -device supports both JSON and dotted keys, we'd still offer a
> (differently ugly) solution for users averse to JSON.
I'm afraid this is not true until we actually QAPIfy -device and change
the non-JSON path to the keyval parser. At the moment, it still uses
qemu_opts_parse_noisily(), so no dotted key syntax.
Kevin
next prev parent reply other threads:[~2023-09-07 13:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-04 16:25 [PATCH 0/1] qom: fix setting of qdev array properties Daniel P. Berrangé
2023-09-04 16:25 ` [PATCH 1/1] qom: fix setting of " Daniel P. Berrangé
2023-09-05 8:58 ` [PATCH 0/1] qom: fix setting of qdev " Kevin Wolf
2023-09-05 9:35 ` Peter Maydell
2023-09-07 9:33 ` Markus Armbruster
2023-09-07 9:35 ` Peter Maydell
2023-09-07 10:06 ` Daniel P. Berrangé
2023-09-08 9:25 ` Kevin Wolf
2023-09-08 9:27 ` Daniel P. Berrangé
2023-09-08 12:16 ` Kevin Wolf
2023-09-08 12:19 ` Daniel P. Berrangé
2023-09-08 9:53 ` Peter Maydell
2023-09-08 12:22 ` Kevin Wolf
2023-09-08 12:52 ` Peter Maydell
2023-09-07 12:59 ` Kevin Wolf [this message]
2023-09-07 14:16 ` Markus Armbruster
2023-09-07 9:45 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPnJRVnC13X25orb@redhat.com \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eduardo@habkost.net \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=williamtsai1111@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).