From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 586E0EE57E7 for ; Fri, 8 Sep 2023 09:28:39 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qeXmT-0008AI-AA; Fri, 08 Sep 2023 05:28:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeXmR-00089L-9A for qemu-devel@nongnu.org; Fri, 08 Sep 2023 05:27:59 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeXmC-0005l8-3K for qemu-devel@nongnu.org; Fri, 08 Sep 2023 05:27:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694165263; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x0ho5n4m/V+mqMwBbhSvaRlVMNUNb5L3Hj2GbRr0S/E=; b=EnTQwCpw2eR4wiyYKyt5Z5Lt0gw4psK74FvLWHRjYSJuMmdDSg5sqiKS3j7RtgSkioQcPm nfHa3+B1b69M88jCEF79h/r3f9oQag6ybFQ0F7Vngh9ePNiEIXxe1d5MJxRQE9HOaMw+m2 v0TLfF14iC7Iq5KWpuNYUvAI39pSEak= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-653-gLfUrkfqMXKSJ6dW8NcyPQ-1; Fri, 08 Sep 2023 05:27:40 -0400 X-MC-Unique: gLfUrkfqMXKSJ6dW8NcyPQ-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A85378001EA; Fri, 8 Sep 2023 09:27:39 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.42]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B1E0A493110; Fri, 8 Sep 2023 09:27:38 +0000 (UTC) Date: Fri, 8 Sep 2023 10:27:36 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Kevin Wolf Cc: Peter Maydell , Markus Armbruster , qemu-devel@nongnu.org, William Tsai , Paolo Bonzini , Eduardo Habkost Subject: Re: [PATCH 0/1] qom: fix setting of qdev array properties Message-ID: References: <20230904162544.2388037-1-berrange@redhat.com> <87edja9vkr.fsf@pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, Sep 08, 2023 at 11:25:54AM +0200, Kevin Wolf wrote: > Am 07.09.2023 um 11:35 hat Peter Maydell geschrieben: > > On Thu, 7 Sept 2023 at 10:33, Markus Armbruster wrote: > > > > > > Kevin Wolf writes: > > > > > > > Am 04.09.2023 um 18:25 hat Daniel P. Berrangé geschrieben: > > > >> By the time of the 8.2.0 release, it will have been 2 years and 6 > > > >> releases since we accidentally broke setting of array properties > > > >> for user creatable devices: > > > >> > > > >> https://gitlab.com/qemu-project/qemu/-/issues/1090 > > > > > > > > Oh, nice! > > > > > > Nice? *Awesome*! > > > > > > > Well, maybe that sounds a bit wrong, but the syntax that was broken was > > > > problematic and more of a hack, > > > > > > A monstrosity, in my opinion. I tried to strangle it in the crib, but > > > its guardians wouldn't let me. Can dig up references for the morbidly > > > curious. > > > > I don't care about the syntax on the command line much (AFAIK that's > > just the rocker device). But the actual feature is used more widely > > within QEMU itself for devices created in C code, which is what it > > was intended for. If you want to get rid of it you need to provide > > an adequate replacement. > > I have a patch to use QList (i.e. JSON lists) that seems to work for the > rocker case. Now I need to find and update all of those internal > callers. Should grepping for '"len-' find all instances that need to be > changed or are you aware of other ways to access the feature? IMHO we can just leave the internal only code callers unchanged. I was about to send this patch to prevent usage leaking into user creatable devices: diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c index 357b8761b5..2d295411ef 100644 --- a/hw/core/qdev-properties.c +++ b/hw/core/qdev-properties.c @@ -584,6 +584,12 @@ static void set_prop_arraylen(Object *obj, Visitor *v, const char *name, void *eltptr; const char *arrayname; int i; + DeviceClass *devc = DEVICE_CLASS(object_get_class(obj)); + + if (devc->user_creatable) { + error_setg(errp, "array property not permitted for user creatable devices"); + return; + } if (*alenptr) { error_setg(errp, "array size property %s may not be set more than once", With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|