From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B3FECEE7FE3 for ; Fri, 8 Sep 2023 12:16:59 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qeaP5-00062j-6b; Fri, 08 Sep 2023 08:16:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeaP3-00062O-JX for qemu-devel@nongnu.org; Fri, 08 Sep 2023 08:16:01 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeaOw-00051a-V4 for qemu-devel@nongnu.org; Fri, 08 Sep 2023 08:16:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694175353; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mMKjpHynsQPEPVHIhBBuanhozIO+huocx+7HwZsKv08=; b=fMg87N344jU4ucK2TYRqgAPRWanNgLGmB2Y4O1vVRX3oBFFWcHlkczxsv9elIC0pGiRkmR hoVq4nFmCn7850LnVek9LJc6YkCidhkfAM8nPSGMbB8o5r9r35Xde9nLzBVA4vFt8EB6nF Ret3OARD+etSzCByXslMpoMSRuF3g6E= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-569-fQ2lLw-vMuyWr5oPHBy_MA-1; Fri, 08 Sep 2023 08:15:50 -0400 X-MC-Unique: fQ2lLw-vMuyWr5oPHBy_MA-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A29B2381AE44; Fri, 8 Sep 2023 12:15:49 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.42]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E30AF493110; Fri, 8 Sep 2023 12:15:48 +0000 (UTC) Date: Fri, 8 Sep 2023 13:15:46 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Ilya Maximets Cc: Stefan Hajnoczi , Jason Wang , qemu-devel@nongnu.org Subject: Re: [PULL 00/17] Net patches Message-ID: References: <20230908064507.14596-1-jasowang@redhat.com> <1186b0b7-7dc5-d926-e6ff-ba3da2238b9c@ovn.org> <4508010f-12e8-8565-d091-e8c68ae0493e@ovn.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4508010f-12e8-8565-d091-e8c68ae0493e@ovn.org> User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, Sep 08, 2023 at 02:00:47PM +0200, Ilya Maximets wrote: > On 9/8/23 13:49, Daniel P. BerrangĂ© wrote: > > On Fri, Sep 08, 2023 at 01:34:54PM +0200, Ilya Maximets wrote: > >> On 9/8/23 13:19, Stefan Hajnoczi wrote: > >>> Hi Ilya and Jason, > >>> There is a CI failure related to a missing Debian libxdp-dev package: > >>> https://gitlab.com/qemu-project/qemu/-/jobs/5046139967 > >>> > >>> I think the issue is that the debian-amd64 container image that QEMU > >>> uses for testing is based on Debian 11 ("bullseye" aka "oldstable") > >>> and libxdp is not available on that release: > >>> https://packages.debian.org/search?keywords=libxdp&searchon=names&suite=oldstable§ion=all > >> > >> Hmm. Sorry about that. > >> > >>> > >>> If we need to support Debian 11 CI then either XDP could be disabled > >>> for that distro or libxdp could be compiled from source. > >> > >> I'd suggest we just remove the attempt to install the package for now, > >> building libxdp from sources may be a little painful to maintain. > >> > >> Can be re-added later once distributions with libxdp 1.4+ will be more > >> widely available, i.e. when fedora dockerfile will be updated to 39, > >> for example. That should be soon-ish, right? > > > > If you follow the process in docs/devel/testing.rst for adding > > libxdp in libvirt-ci, then lcitool will "do the right thing" > > when we move the auto-generated dockerfiles to new distro versions. > > Thanks! I'll prepare changes for libvirt-ci. > > In the meantime, none of the currently tested images will have a required > version of libxdp anyway, so I'm suggesting to just drop this one dockerfile > modification from the patch. What do you think? Sure, if none of the distros have it, then lcitool won't emit the dockerfile changes until we update the inherited distro version. So it is sufficient to just update libvirt-ci.git with the mappings.yml info for libxdp, and add 'libxdp' to the tests/lcitool/projects/qemu.yml file in qemu.git. It will then 'just work' when someone updates the distro versions later. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|