qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Steve Sistare <steven.sistare@oracle.com>
Cc: qemu-devel@nongnu.org, Peter Xu <peterx@redhat.com>,
	Juan Quintela <quintela@redhat.com>,
	Fabiano Rosas <farosas@suse.de>,
	Claudio Fontana <cfontana@suse.de>
Subject: Re: [PATCH V5 2/2] migration: file URI offset
Date: Fri, 8 Sep 2023 15:27:54 +0100	[thread overview]
Message-ID: <ZPsvalXCW5p6egVv@redhat.com> (raw)
In-Reply-To: <1694182931-61390-3-git-send-email-steven.sistare@oracle.com>

On Fri, Sep 08, 2023 at 07:22:11AM -0700, Steve Sistare wrote:
> Allow an offset option to be specified as part of the file URI, in
> the form "file:filename,offset=offset", where offset accepts the common
> size suffixes, or the 0x prefix, but not both.  Migration data is written
> to and read from the file starting at offset.  If unspecified, it defaults
> to 0.
> 
> This is needed by libvirt to store its own data at the head of the file.
> 
> Suggested-by: Daniel P. Berrange <berrange@redhat.com>
> Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
> Reviewed-by: Peter Xu <peterx@redhat.com>
> ---
>  migration/file.c | 45 +++++++++++++++++++++++++++++++++++++++++++--
>  qemu-options.hx  |  7 ++++---
>  2 files changed, 47 insertions(+), 5 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



  reply	other threads:[~2023-09-08 14:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-08 14:22 [PATCH V5 0/2] migration file URI Steve Sistare
2023-09-08 14:22 ` [PATCH V5 1/2] migration: " Steve Sistare
2023-09-08 14:28   ` Daniel P. Berrangé
2023-10-04 11:01   ` Juan Quintela
2023-09-08 14:22 ` [PATCH V5 2/2] migration: file URI offset Steve Sistare
2023-09-08 14:27   ` Daniel P. Berrangé [this message]
2023-10-04 11:17   ` Juan Quintela
2023-09-13 13:05 ` [PATCH V5 0/2] migration file URI Claudio Fontana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZPsvalXCW5p6egVv@redhat.com \
    --to=berrange@redhat.com \
    --cc=cfontana@suse.de \
    --cc=farosas@suse.de \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=steven.sistare@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).