qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-devel@nongnu.org, "Thomas Huth" <thuth@redhat.com>,
	"Beraldo Leal" <bleal@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>
Subject: Re: [PATCH] gitlab-ci/cirrus: Increase timeout to 100 minutes
Date: Tue, 12 Sep 2023 14:52:31 +0100	[thread overview]
Message-ID: <ZQBtH7rBWm2Sze68@redhat.com> (raw)
In-Reply-To: <20230912133829.61352-1-stefanha@redhat.com>

On Tue, Sep 12, 2023 at 09:38:29AM -0400, Stefan Hajnoczi wrote:
> The 80m timeout is not enough:
> 
>   672/832 qemu:block / io-qcow2-041          OK             39.77s   1 subtests passed
>   Timed out!

IIUC, that 'timed out' message is coming from Cirrus CI logs, which
we can see over on the cirrus task:

  https://cirrus-ci.com/task/6462328380588032

> https://gitlab.com/qemu-project/qemu/-/jobs/5058610599

This reports duration "64 minutes", vs a GitLab timeout of 1hr20.

IOW, we're not hitting the gitlab timeout, we're hitting hte
Cirrus CI timeout, which defaults to 60 minutes.  The other
4 minuts gitlab reports is likely because Cirrus queued the
job for 4 minutes before starting execution.

> 
> Buglink: https://gitlab.com/qemu-project/qemu/-/issues/1882
> Fixes: d06f3bf92267 ("gitlab-ci/cirrus: Increase timeout to 80 minutes")
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  .gitlab-ci.d/cirrus.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.gitlab-ci.d/cirrus.yml b/.gitlab-ci.d/cirrus.yml
> index 41d64d6680..d19633f758 100644
> --- a/.gitlab-ci.d/cirrus.yml
> +++ b/.gitlab-ci.d/cirrus.yml
> @@ -15,7 +15,7 @@
>    stage: build
>    image: registry.gitlab.com/libvirt/libvirt-ci/cirrus-run:master
>    needs: []
> -  timeout: 80m
> +  timeout: 100m
>    allow_failure: true
>    script:
>      - source .gitlab-ci.d/cirrus/$NAME.vars

IIUC, we need to put a 'timeout_in' setting someone in
.gitlab-ci.d/cirrus/build.yml instead, to override
Cirrus 60 minute limit:

https://cirrus-ci.org/faq/#instance-timed-out


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



  reply	other threads:[~2023-09-12 13:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-12 13:38 [PATCH] gitlab-ci/cirrus: Increase timeout to 100 minutes Stefan Hajnoczi
2023-09-12 13:52 ` Daniel P. Berrangé [this message]
2023-09-12 14:02   ` Stefan Hajnoczi
2023-09-12 14:15     ` Daniel P. Berrangé
2023-09-12 14:17       ` Stefan Hajnoczi
2023-09-12 16:36       ` Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZQBtH7rBWm2Sze68@redhat.com \
    --to=berrange@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=bleal@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).