From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BCB2FCA0EEB for ; Tue, 12 Sep 2023 15:21:22 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qg5BW-0008Qt-No; Tue, 12 Sep 2023 11:20:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qg5BU-0008QI-LY for qemu-devel@nongnu.org; Tue, 12 Sep 2023 11:20:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qg5BR-0002eU-Bf for qemu-devel@nongnu.org; Tue, 12 Sep 2023 11:20:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694532007; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=CWXTNOyFA1pnzqAxFc+vV5e1GJo6GOBKpDwzGmjpC9g=; b=LWFqIEe1nwFmmJSwBSvoJPBJtKLEVTJXLtsOZcv2ptDkbxXK5MGABVOh9Pa/hdrueCUhod /+CoCpGUIidgL7+Iw3LMfbPjvzv9j0RpjEzY3kQoqvLkHWe8Vq1uoKmU2Km5EdKPMP2ZIE NJi1/anVDxOq4v95hV4c8fsclthTB9g= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-647-qiCdzlDCP9C1u1T0wtMGVg-1; Tue, 12 Sep 2023 11:20:04 -0400 X-MC-Unique: qiCdzlDCP9C1u1T0wtMGVg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id ADE1B3C100AD; Tue, 12 Sep 2023 15:20:03 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.38]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ADAA510F1BE8; Tue, 12 Sep 2023 15:20:02 +0000 (UTC) Date: Tue, 12 Sep 2023 16:20:00 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, Wainer dos Santos Moschetta , Thomas Huth , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Beraldo Leal , Alex =?utf-8?Q?Benn=C3=A9e?= Subject: Re: [PATCH] gitlab: remove unreliable avocado CI jobs Message-ID: References: <20230912150611.70676-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230912150611.70676-1-stefanha@redhat.com> User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Sep 12, 2023 at 11:06:11AM -0400, Stefan Hajnoczi wrote: > The avocado-system-alpine, avocado-system-fedora, and > avocado-system-ubuntu jobs are unreliable. I identified them while > looking over CI failures from the past week: > https://gitlab.com/qemu-project/qemu/-/jobs/5058610614 > https://gitlab.com/qemu-project/qemu/-/jobs/5058610654 > https://gitlab.com/qemu-project/qemu/-/jobs/5030428571 > > Thomas Huth suggest on IRC today that there may be a legitimate failure > in there: > > th_huth: f4bug, yes, seems like it does not start at all correctly on > alpine anymore ... and it's broken since ~ 2 weeks already, so if nobody > noticed this by now, this is worrying > > It crept in because the jobs were already unreliable. > > I don't know how to interpret the job output, so all I can do is to > propose removing these jobs. A useful CI job has two outcomes: pass or > fail. Timeouts and other in-between states are not useful because they > require constant triaging by someone who understands the details of the > tests and they can occur when run against pull requests that have > nothing to do with the area covered by the test. > > Hopefully test owners will be able to identify the root causes and solve > them so that these jobs can stay. In their current state the jobs are > not useful since I cannot cannot tell whether job failures are real or > just intermittent when merging qemu.git pull requests. > > If you are a test owner, please take a look. > > It is likely that other avocado-system-* CI jobs have similar failures > from time to time, but I'll leave them as long as they are passing. > > Buglink: https://gitlab.com/qemu-project/qemu/-/issues/1884 > Signed-off-by: Stefan Hajnoczi > --- > .gitlab-ci.d/buildtest.yml | 27 --------------------------- > 1 file changed, 27 deletions(-) > > diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml > index aee9101507..83ce448c4d 100644 > --- a/.gitlab-ci.d/buildtest.yml > +++ b/.gitlab-ci.d/buildtest.yml > @@ -22,15 +22,6 @@ check-system-alpine: > IMAGE: alpine > MAKE_CHECK_ARGS: check-unit check-qtest > > -avocado-system-alpine: > - extends: .avocado_test_job_template > - needs: > - - job: build-system-alpine > - artifacts: true > - variables: > - IMAGE: alpine > - MAKE_CHECK_ARGS: check-avocado Instead of entirely deleting, I'd suggest adding # Disabled due to frequent random failures # https://gitlab.com/qemu-project/qemu/-/issues/1884 when: manual See example: https://docs.gitlab.com/ee/ci/yaml/#when This disables the job from running unless someone explicitly tells it to run > - > build-system-ubuntu: > extends: > - .native_build_job_template > @@ -53,15 +44,6 @@ check-system-ubuntu: > IMAGE: ubuntu2204 > MAKE_CHECK_ARGS: check > > -avocado-system-ubuntu: > - extends: .avocado_test_job_template > - needs: > - - job: build-system-ubuntu > - artifacts: true > - variables: > - IMAGE: ubuntu2204 > - MAKE_CHECK_ARGS: check-avocado > - > build-system-debian: > extends: > - .native_build_job_template > @@ -127,15 +109,6 @@ check-system-fedora: > IMAGE: fedora > MAKE_CHECK_ARGS: check > > -avocado-system-fedora: > - extends: .avocado_test_job_template > - needs: > - - job: build-system-fedora > - artifacts: true > - variables: > - IMAGE: fedora > - MAKE_CHECK_ARGS: check-avocado > - > crash-test-fedora: > extends: .native_test_job_template > needs: > -- > 2.41.0 > > With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|