qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: Daniil Tatianin <d-tatianin@yandex-team.ru>
Cc: Juan Quintela <quintela@redhat.com>,
	Leonardo Bras <leobras@redhat.com>,
	qemu-devel@nongnu.org, yc-core@yandex-team.ru
Subject: Re: [PATCH v1 0/2] i386/a-b-bootblock: zero the first byte of each page on start
Date: Wed, 13 Sep 2023 15:22:41 -0400	[thread overview]
Message-ID: <ZQIMAdfjmwGsxeME@x1n> (raw)
In-Reply-To: <20230907193051.1609310-1-d-tatianin@yandex-team.ru>

On Thu, Sep 07, 2023 at 10:30:49PM +0300, Daniil Tatianin wrote:
> This series fixes an issue where the outcome of the migration qtest
> relies on the initial memory contents all being the same across the
> first 100MiB of RAM, which is a very fragile invariant.
> 
> We fix this by making sure we zero the first byte of every testable page
> in range beforehand.
> 
> Daniil Tatianin (2):
>   i386/a-b-bootblock: factor test memory addresses out into constants
>   i386/a-b-bootblock: zero the first byte of each page on start

Thanks, sorry for being slow on review.

Reviewed-by: Peter Xu <peterx@redhat.com>

How about other archs (arm/s390)?   It seems to me arm is all fine, but not
sure about s390.

-- 
Peter Xu



      parent reply	other threads:[~2023-09-13 19:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-07 19:30 [PATCH v1 0/2] i386/a-b-bootblock: zero the first byte of each page on start Daniil Tatianin
2023-09-07 19:30 ` [PATCH v1 1/2] i386/a-b-bootblock: factor test memory addresses out into constants Daniil Tatianin
2023-09-07 19:30 ` [PATCH v1 2/2] i386/a-b-bootblock: zero the first byte of each page on start Daniil Tatianin
2023-09-13 14:49 ` [PATCH v1 0/2] " Daniil Tatianin
2023-09-13 19:22 ` Peter Xu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZQIMAdfjmwGsxeME@x1n \
    --to=peterx@redhat.com \
    --cc=d-tatianin@yandex-team.ru \
    --cc=leobras@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=yc-core@yandex-team.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).