From: Kevin Wolf <kwolf@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, hreitz@redhat.com, eblake@redhat.com,
vsementsov@yandex-team.ru, jsnow@redhat.com, idryomov@gmail.com,
pl@kamp.de, sw@weilnetz.de, sstabellini@kernel.org,
anthony.perard@citrix.com, paul@xen.org, pbonzini@redhat.com,
marcandre.lureau@redhat.com, berrange@redhat.com,
thuth@redhat.com, philmd@linaro.org, stefanha@redhat.com,
fam@euphon.net, quintela@redhat.com, peterx@redhat.com,
leobras@redhat.com, kraxel@redhat.com, qemu-block@nongnu.org,
xen-devel@lists.xenproject.org, alex.bennee@linaro.org,
peter.maydell@linaro.org
Subject: Re: [PATCH v2 5/7] block/vdi: Clean up local variable shadowing
Date: Thu, 21 Sep 2023 10:29:41 +0200 [thread overview]
Message-ID: <ZQv+9cf9QivEQHQD@redhat.com> (raw)
In-Reply-To: <20230920183149.1105333-6-armbru@redhat.com>
Am 20.09.2023 um 20:31 hat Markus Armbruster geschrieben:
> Local variables shadowing other local variables or parameters make the
> code needlessly hard to understand. Tracked down with -Wshadow=local.
> Clean up: delete inner declarations when they are actually redundant,
> else rename variables.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
next prev parent reply other threads:[~2023-09-21 8:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 18:31 [PATCH v2 0/7] Steps towards enabling -Wshadow=local Markus Armbruster
2023-09-20 18:31 ` [PATCH v2 1/7] migration/rdma: Fix save_page method to fail on polling error Markus Armbruster
2023-09-20 18:31 ` [PATCH v2 2/7] migration: Clean up local variable shadowing Markus Armbruster
2023-09-21 6:06 ` Zhijian Li (Fujitsu)
2023-09-20 18:31 ` [PATCH v2 3/7] ui: " Markus Armbruster
2023-09-20 18:31 ` [PATCH v2 4/7] block/dirty-bitmap: " Markus Armbruster
2023-09-21 8:37 ` Kevin Wolf
2023-09-20 18:31 ` [PATCH v2 5/7] block/vdi: " Markus Armbruster
2023-09-21 8:29 ` Kevin Wolf [this message]
2023-09-20 18:31 ` [PATCH v2 6/7] block: " Markus Armbruster
2023-09-21 8:33 ` Kevin Wolf
2023-09-20 18:31 ` [PATCH v2 7/7] qobject atomics osdep: Make a few macros more hygienic Markus Armbruster
2023-09-20 20:10 ` Eric Blake
2023-09-21 5:14 ` Markus Armbruster
2023-09-21 8:42 ` Kevin Wolf
2023-09-21 11:23 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQv+9cf9QivEQHQD@redhat.com \
--to=kwolf@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=anthony.perard@citrix.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=fam@euphon.net \
--cc=hreitz@redhat.com \
--cc=idryomov@gmail.com \
--cc=jsnow@redhat.com \
--cc=kraxel@redhat.com \
--cc=leobras@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=pl@kamp.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=sstabellini@kernel.org \
--cc=stefanha@redhat.com \
--cc=sw@weilnetz.de \
--cc=thuth@redhat.com \
--cc=vsementsov@yandex-team.ru \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).