From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 95734E7B5E5 for ; Wed, 4 Oct 2023 10:16:59 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qnyvR-0001Pu-Ls; Wed, 04 Oct 2023 06:16:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qnyvM-0001PQ-DZ for qemu-devel@nongnu.org; Wed, 04 Oct 2023 06:16:13 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qnyvK-0004hn-9t for qemu-devel@nongnu.org; Wed, 04 Oct 2023 06:16:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696414568; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+gqiFWuPI2O5e5JF9sAtACpeMRqQSrJ7i/TeLn89wLs=; b=LvOH0B2beOh39RQyMCSzCFPgmnJw2Km9e+N0+aG4LS7SyaXUUCDtzjnsyVOKS5PzgRyXOS 57NqwVSNmNaRXTumktEUkW/eU1CAfvTAZyUX46FxURL5zpbyxfl04NEN45a0NVOA2SWByQ HRtK8QTBcb7xrzke3IjNIt1QafnaTe8= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-379-mobpcv1HNBi2EdlPC95m1A-1; Wed, 04 Oct 2023 06:15:57 -0400 X-MC-Unique: mobpcv1HNBi2EdlPC95m1A-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5707F3800EB5; Wed, 4 Oct 2023 10:15:57 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 989132156701; Wed, 4 Oct 2023 10:15:56 +0000 (UTC) Date: Wed, 4 Oct 2023 11:15:54 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: Markus Armbruster , QEMU Developers , Thomas Huth , Paolo Bonzini Subject: Re: Wshadow: Better name for 'optarg'? Message-ID: References: <14cd0201-1507-bfa8-fe9e-f482c35d21ca@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <14cd0201-1507-bfa8-fe9e-f482c35d21ca@linaro.org> User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, Oct 04, 2023 at 12:05:04PM +0200, Philippe Mathieu-Daudé wrote: > Hi, > > I'm getting a bunch of errors for 'optarg' declared in : > > NAME > getopt – get option character from command line argument list > > LIBRARY > Standard C Library (libc, -lc) > > SYNOPSIS > #include > > extern char *optarg; > > > qom/object_interfaces.c:262:53: error: declaration shadows a variable in the > global scope [-Werror,-Wshadow] > ObjectOptions *user_creatable_parse_str(const char *optarg, Error **errp) snip > Do we want to clean those? Any good name suggestion? Yes. any of "argval", "opts", "optstr", "optval". With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|