qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org, qemu-riscv@nongnu.org,
	Thomas Huth <thuth@redhat.com>,
	qemu-ppc@nongnu.org, qemu-s390x@nongnu.org, qemu-arm@nongnu.org,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 00/13] misc: Rename 'softmmu' -> 'system'
Date: Wed, 4 Oct 2023 13:33:18 +0100	[thread overview]
Message-ID: <ZR1bjpEi5HdFp2xj@redhat.com> (raw)
In-Reply-To: <20231004090629.37473-1-philmd@linaro.org>

On Wed, Oct 04, 2023 at 11:06:15AM +0200, Philippe Mathieu-Daudé wrote:
> This series finishes the cleanup which remove the confusion
> of using 'softmmu' when we really mean 'system emulation',
> as opposition to 'user emulation'.

Am I mis-understanding what you mean by 'finishes' here, as
I see many references to softmmu remaining

  $ git grep softmmu | wc -l
  270

In particular under configs/

I was also hoping it meant that we'd be changing configure
to allow

    configure --target-list=x86_64-system

though the lazy side of me would like

    configure --target-list=x86_64-vm

for less typing

> 
> Now that Richard posted its "tcg: Allow softmmu for user-only"
> series, this is particularly relevant:
> https://lore.kernel.org/qemu-devel/20231003174356.1602279-1-richard.henderson@linaro.org/
> 
> Philippe Mathieu-Daudé (13):
>   softmmu/trace-events: Fix a typo
>   travis-ci: Correct invalid mentions of 'softmmu' by 'system'
>   cpu: Correct invalid mentions of 'softmmu' by 'system-mode'
>   fuzz: Correct invalid mentions of 'softmmu' by 'system'
>   tcg: Correct invalid mentions of 'softmmu' by 'system-mode'
>   accel: Rename accel_softmmu* -> accel_system*
>   gdbstub: Rename 'softmmu' -> 'system'
>   semihosting: Rename softmmu_FOO_user() -> uaccess_FOO_user()
>   target/i386: Rename i386_softmmu_kvm_ss -> i386_kvm_ss
>   hw/virtio/meson: Rename softmmu_virtio_ss -> system_virtio_ss
>   meson: Rename softmmu_mods -> system_mods
>   meson: Rename target_softmmu_arch -> target_system_arch
>   system: Rename softmmu/ directory as system/
> 
>  MAINTAINERS                                   | 44 +++++++++----------
>  docs/devel/build-system.rst                   |  4 +-
>  docs/devel/qtest.rst                          |  2 +-
>  docs/devel/testing.rst                        |  2 +-
>  tests/tcg/s390x/pgm-specification.mak         |  2 +-
>  meson.build                                   | 22 +++++-----
>  accel/{accel-softmmu.h => accel-system.h}     |  6 +--
>  gdbstub/internals.h                           |  4 +-
>  include/qemu/atomic128.h                      |  4 +-
>  .../{softmmu-uaccess.h => uaccess.h}          | 24 +++++-----
>  include/sysemu/runstate-action.h              |  2 +-
>  include/tcg/tcg-op-common.h                   |  2 +-
>  softmmu/trace.h                               |  1 -
>  {softmmu => system}/timers-state.h            |  0
>  system/trace.h                                |  1 +
>  tests/qtest/fuzz/fuzz.h                       |  4 +-
>  accel/accel-common.c                          |  2 +-
>  accel/{accel-softmmu.c => accel-system.c}     |  6 +--
>  accel/tcg/user-exec.c                         |  2 +-
>  cpu.c                                         |  2 +-
>  gdbstub/{softmmu.c => system.c}               |  2 +-
>  hw/core/cpu-common.c                          |  4 +-
>  semihosting/arm-compat-semi.c                 |  4 +-
>  semihosting/config.c                          |  2 +-
>  semihosting/guestfd.c                         |  2 +-
>  semihosting/syscalls.c                        |  2 +-
>  semihosting/uaccess.c                         | 14 +++---
>  stubs/semihost.c                              |  4 +-
>  {softmmu => system}/arch_init.c               |  0
>  {softmmu => system}/async-teardown.c          |  0
>  {softmmu => system}/balloon.c                 |  0
>  {softmmu => system}/bootdevice.c              |  0
>  {softmmu => system}/cpu-throttle.c            |  0
>  {softmmu => system}/cpu-timers.c              |  0
>  {softmmu => system}/cpus.c                    |  0
>  {softmmu => system}/datadir.c                 |  0
>  {softmmu => system}/device_tree.c             |  0
>  {softmmu => system}/dirtylimit.c              |  0
>  {softmmu => system}/dma-helpers.c             |  0
>  {softmmu => system}/globals.c                 |  0
>  {softmmu => system}/icount.c                  |  0
>  {softmmu => system}/ioport.c                  |  0
>  {softmmu => system}/main.c                    |  0
>  {softmmu => system}/memory.c                  |  2 +-
>  {softmmu => system}/memory_mapping.c          |  0
>  {softmmu => system}/physmem.c                 |  6 ++-
>  {softmmu => system}/qdev-monitor.c            |  0
>  {softmmu => system}/qemu-seccomp.c            |  0
>  {softmmu => system}/qtest.c                   |  0
>  {softmmu => system}/rtc.c                     |  0
>  {softmmu => system}/runstate-action.c         |  0
>  {softmmu => system}/runstate-hmp-cmds.c       |  0
>  {softmmu => system}/runstate.c                |  0
>  {softmmu => system}/tpm-hmp-cmds.c            |  0
>  {softmmu => system}/tpm.c                     |  0
>  {softmmu => system}/vl.c                      |  0
>  {softmmu => system}/watchpoint.c              |  0
>  target/m68k/m68k-semi.c                       |  2 +-
>  target/mips/tcg/sysemu/mips-semi.c            |  2 +-
>  target/nios2/nios2-semi.c                     |  2 +-
>  target/riscv/vector_helper.c                  |  2 +-
>  tcg/region.c                                  |  4 +-
>  tcg/tcg.c                                     | 11 ++---
>  tests/qtest/fuzz/fuzz.c                       |  2 +-
>  tests/tcg/multiarch/system/memory.c           |  4 +-
>  tcg/aarch64/tcg-target.c.inc                  |  4 +-
>  tcg/arm/tcg-target.c.inc                      |  2 +-
>  tcg/i386/tcg-target.c.inc                     |  2 +-
>  tcg/loongarch64/tcg-target.c.inc              |  4 +-
>  tcg/mips/tcg-target.c.inc                     |  4 +-
>  tcg/ppc/tcg-target.c.inc                      |  4 +-
>  tcg/riscv/tcg-target.c.inc                    |  4 +-
>  tcg/s390x/tcg-target.c.inc                    |  4 +-
>  tcg/sparc64/tcg-target.c.inc                  |  4 +-
>  .travis.yml                                   |  4 +-
>  accel/meson.build                             |  2 +-
>  accel/stubs/meson.build                       | 10 ++---
>  gdbstub/meson.build                           | 10 ++---
>  gdbstub/trace-events                          |  2 +-
>  hw/virtio/meson.build                         | 22 +++++-----
>  scripts/checkpatch.pl                         |  2 +-
>  scripts/coverity-scan/COMPONENTS.md           |  2 +-
>  scripts/get_maintainer.pl                     |  2 +-
>  {softmmu => system}/meson.build               |  0
>  {softmmu => system}/trace-events              |  2 +-
>  target/alpha/meson.build                      |  2 +-
>  target/arm/meson.build                        |  2 +-
>  target/avr/meson.build                        |  2 +-
>  target/cris/meson.build                       |  2 +-
>  target/hppa/meson.build                       |  2 +-
>  target/i386/kvm/meson.build                   | 10 ++---
>  target/i386/meson.build                       |  2 +-
>  target/loongarch/meson.build                  |  2 +-
>  target/m68k/meson.build                       |  2 +-
>  target/microblaze/meson.build                 |  2 +-
>  target/mips/meson.build                       |  2 +-
>  target/nios2/meson.build                      |  2 +-
>  target/openrisc/meson.build                   |  2 +-
>  target/ppc/meson.build                        |  2 +-
>  target/riscv/meson.build                      |  2 +-
>  target/rx/meson.build                         |  2 +-
>  target/s390x/meson.build                      |  2 +-
>  target/sh4/meson.build                        |  2 +-
>  target/sparc/meson.build                      |  2 +-
>  target/tricore/meson.build                    |  2 +-
>  target/xtensa/meson.build                     |  2 +-
>  tcg/meson.build                               |  6 +--
>  tests/tcg/Makefile.target                     |  2 +-
>  tests/tcg/multiarch/gdbstub/interrupt.py      |  2 +-
>  tests/tcg/multiarch/gdbstub/memory.py         |  2 +-
>  tests/tcg/s390x/pgm-specification-softmmu.S   |  2 +-
>  tests/tcg/s390x/softmmu.ld                    |  2 +-
>  tests/tcg/xtensa/Makefile.softmmu-target      |  2 +-
>  tests/tcg/xtensaeb/Makefile.softmmu-target    |  2 +-
>  tests/unit/meson.build                        |  2 +-
>  115 files changed, 188 insertions(+), 181 deletions(-)
>  rename accel/{accel-softmmu.h => accel-system.h} (77%)
>  rename include/semihosting/{softmmu-uaccess.h => uaccess.h} (75%)
>  delete mode 100644 softmmu/trace.h
>  rename {softmmu => system}/timers-state.h (100%)
>  create mode 100644 system/trace.h
>  rename accel/{accel-softmmu.c => accel-system.c} (96%)
>  rename gdbstub/{softmmu.c => system.c} (99%)
>  rename {softmmu => system}/arch_init.c (100%)
>  rename {softmmu => system}/async-teardown.c (100%)
>  rename {softmmu => system}/balloon.c (100%)
>  rename {softmmu => system}/bootdevice.c (100%)
>  rename {softmmu => system}/cpu-throttle.c (100%)
>  rename {softmmu => system}/cpu-timers.c (100%)
>  rename {softmmu => system}/cpus.c (100%)
>  rename {softmmu => system}/datadir.c (100%)
>  rename {softmmu => system}/device_tree.c (100%)
>  rename {softmmu => system}/dirtylimit.c (100%)
>  rename {softmmu => system}/dma-helpers.c (100%)
>  rename {softmmu => system}/globals.c (100%)
>  rename {softmmu => system}/icount.c (100%)
>  rename {softmmu => system}/ioport.c (100%)
>  rename {softmmu => system}/main.c (100%)
>  rename {softmmu => system}/memory.c (99%)
>  rename {softmmu => system}/memory_mapping.c (100%)
>  rename {softmmu => system}/physmem.c (99%)
>  rename {softmmu => system}/qdev-monitor.c (100%)
>  rename {softmmu => system}/qemu-seccomp.c (100%)
>  rename {softmmu => system}/qtest.c (100%)
>  rename {softmmu => system}/rtc.c (100%)
>  rename {softmmu => system}/runstate-action.c (100%)
>  rename {softmmu => system}/runstate-hmp-cmds.c (100%)
>  rename {softmmu => system}/runstate.c (100%)
>  rename {softmmu => system}/tpm-hmp-cmds.c (100%)
>  rename {softmmu => system}/tpm.c (100%)
>  rename {softmmu => system}/vl.c (100%)
>  rename {softmmu => system}/watchpoint.c (100%)
>  rename {softmmu => system}/meson.build (100%)
>  rename {softmmu => system}/trace-events (99%)
> 
> -- 
> 2.41.0
> 
> 

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



  parent reply	other threads:[~2023-10-04 12:34 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-04  9:06 [PATCH 00/13] misc: Rename 'softmmu' -> 'system' Philippe Mathieu-Daudé
2023-10-04  9:06 ` [PATCH 01/13] softmmu/trace-events: Fix a typo Philippe Mathieu-Daudé
2023-10-04  9:06 ` [PATCH 02/13] travis-ci: Correct invalid mentions of 'softmmu' by 'system' Philippe Mathieu-Daudé
2023-10-04  9:06 ` [PATCH 03/13] cpu: Correct invalid mentions of 'softmmu' by 'system-mode' Philippe Mathieu-Daudé
2023-10-04  9:06 ` [PATCH 04/13] fuzz: Correct invalid mentions of 'softmmu' by 'system' Philippe Mathieu-Daudé
2023-10-04  9:22   ` Alexander Bulekov
2023-10-04  9:06 ` [PATCH 05/13] tcg: Correct invalid mentions of 'softmmu' by 'system-mode' Philippe Mathieu-Daudé
2023-10-04  9:06 ` [PATCH 06/13] accel: Rename accel_softmmu* -> accel_system* Philippe Mathieu-Daudé
2023-10-04  9:06 ` [PATCH 07/13] gdbstub: Rename 'softmmu' -> 'system' Philippe Mathieu-Daudé
2023-10-04 15:23   ` Alex Bennée
2023-10-04  9:06 ` [PATCH 08/13] semihosting: Rename softmmu_FOO_user() -> uaccess_FOO_user() Philippe Mathieu-Daudé
2023-10-04  9:06 ` [PATCH 09/13] target/i386: Rename i386_softmmu_kvm_ss -> i386_kvm_ss Philippe Mathieu-Daudé
2023-10-04  9:06 ` [PATCH 10/13] hw/virtio/meson: Rename softmmu_virtio_ss -> system_virtio_ss Philippe Mathieu-Daudé
2023-10-04  9:06 ` [PATCH 11/13] meson: Rename softmmu_mods -> system_mods Philippe Mathieu-Daudé
2023-10-04  9:06 ` [PATCH 12/13] meson: Rename target_softmmu_arch -> target_system_arch Philippe Mathieu-Daudé
2023-10-04  9:06 ` [PATCH 13/13] system: Rename softmmu/ directory as system/ Philippe Mathieu-Daudé
2023-10-04 12:03   ` Philippe Mathieu-Daudé
2023-10-04 12:46     ` BALATON Zoltan
2023-10-04 12:33 ` Daniel P. Berrangé [this message]
2023-10-04 12:37   ` [PATCH 00/13] misc: Rename 'softmmu' -> 'system' Thomas Huth
2023-10-04 12:51     ` Daniel P. Berrangé
2023-10-04 13:41     ` Claudio Fontana
2023-10-04 13:49       ` Paolo Bonzini
2023-10-04 13:53         ` Daniel P. Berrangé
2023-10-06  7:49           ` Thomas Huth
2023-10-04 14:06         ` Philippe Mathieu-Daudé
2023-10-04 13:20 ` Paolo Bonzini
2023-10-04 13:26   ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZR1bjpEi5HdFp2xj@redhat.com \
    --to=berrange@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).