From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 46E09CD80B0 for ; Tue, 10 Oct 2023 11:52:08 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qqBGh-0007tJ-Qd; Tue, 10 Oct 2023 07:51:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qqBGf-0007ow-Fx for qemu-devel@nongnu.org; Tue, 10 Oct 2023 07:51:18 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qqBGd-00072O-Aa for qemu-devel@nongnu.org; Tue, 10 Oct 2023 07:51:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696938671; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=ZOhCdUZSoyDy7RW411TpTrHbpiHeI9FVoha0+mNGq/8=; b=eZrkIBQPEMAodMyvZFwadL1uuL8SELPCUbOrPS1isKKRxe5N3pSE3q1CNWWRx8PO+omHB6 RBdlOK8zgVjlqX7Wq2Pate+ekoeYCSq1ZjQJypEhF9eLE0ZoCKkTxprFxxGdQkmtY6AJLw KBM4EwWiYyAC9xLZAa6vWpOl1wZKzG8= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-688-_Z6j7pO0OdGQzsJlpV6pmg-1; Tue, 10 Oct 2023 07:51:08 -0400 X-MC-Unique: _Z6j7pO0OdGQzsJlpV6pmg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 815681C0651E; Tue, 10 Oct 2023 11:51:07 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.49]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1828F15C39; Tue, 10 Oct 2023 11:51:04 +0000 (UTC) Date: Tue, 10 Oct 2023 12:51:02 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Dmitry Osipenko Cc: Huang Rui , Gerd Hoffmann , "Michael S . Tsirkin" , Akihiko Odaki , Stefano Stabellini , Anthony PERARD , Antonio Caggiano , "Dr . David Alan Gilbert" , Robert Beckett , Alex =?utf-8?Q?Benn=C3=A9e?= , qemu-devel@nongnu.org, xen-devel@lists.xenproject.org, Gurchetan Singh , Albert Esteve , ernunes@redhat.com, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Alyssa Ross , Roger Pau =?utf-8?B?TW9ubsOp?= , Alex Deucher , Christian =?utf-8?B?S8O2bmln?= , Xenia Ragiadakou , Pierre-Eric Pelloux-Prayer , Honglei Huang , Julia Zhang , Chen Jiqian Subject: Re: [QEMU PATCH v5 05/13] virtio-gpu: Configure context init for virglrenderer Message-ID: References: <20230915111130.24064-1-ray.huang@amd.com> <20230915111130.24064-6-ray.huang@amd.com> <16520a76-7177-f97c-049b-302d8baea616@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <16520a76-7177-f97c-049b-302d8baea616@collabora.com> User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Oct 10, 2023 at 02:41:22PM +0300, Dmitry Osipenko wrote: > On 9/15/23 14:11, Huang Rui wrote: > > Configure context init feature flag for virglrenderer. > > > > Originally-by: Antonio Caggiano > > Signed-off-by: Huang Rui > > --- > > > > V4 -> V5: > > - Inverted patch 5 and 6 because we should configure > > HAVE_VIRGL_CONTEXT_INIT firstly. (Philippe) > > > > meson.build | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/meson.build b/meson.build > > index 98e68ef0b1..ff20d3c249 100644 > > --- a/meson.build > > +++ b/meson.build > > @@ -1068,6 +1068,10 @@ if not get_option('virglrenderer').auto() or have_system or have_vhost_user_gpu > > prefix: '#include ', > > dependencies: virgl)) > > endif > > + config_host_data.set('HAVE_VIRGL_CONTEXT_INIT', > > + cc.has_function('virgl_renderer_context_create_with_flags', > > + prefix: '#include ', > > + dependencies: virgl)) > The "cc.has_function" doesn't work properly with PKG_CONFIG_PATH. It ignores the the given pkg and uses system includes. Antonio was aware about that problem [1]. > > [1] https://gitlab.freedesktop.org/Fahien/qemu/-/commit/ea1c252a707940983ccce71e92a292b49496bfcd > > Given that virglrenderer 1.0 has been released couple weeks ago, > can we make the v1.0 a mandatory requirement for qemu and remove > all the ifdefs? I doubt that anyone is going to test newer qemu > using older libviglrenderer, all that ifdef code will be bitrotting. We cannot do that. If is is only weeks old, no distro will have virglrenderer 1.0 present. QEMU has a defined set of platforms that it targets compatibility with: https://www.qemu.org/docs/master/about/build-platforms.html For newly added functionality we can set the min version to something newer than the oldest QEMU target platform. For existing functionality though, we must not regress wrt the currently supported set of target platforms. So we can only bump the min version to that present in the oldest platform we target. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|