From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7BECACD80CE for ; Tue, 10 Oct 2023 13:02:45 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qqCN3-0006ad-07; Tue, 10 Oct 2023 09:02:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qqCMW-0006QF-HU for qemu-devel@nongnu.org; Tue, 10 Oct 2023 09:01:33 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qqCMU-0006f0-U9 for qemu-devel@nongnu.org; Tue, 10 Oct 2023 09:01:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696942882; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g7E5LZqxhYAGWBXDWwkW2Y2kQIX7oZaDJ41VKMqh+xM=; b=aVzLgUwiFf2hk8At3P034jzGDSKjRXXu+RoynJJW8uaYJlRRZEOVJSlnhP9BQBg475ZmtY stNwInlNSy8aVbF71O6VEH54XUHpOSMdX7bAoTu4YfIaLQUbr4si1+oGg4s5Edw4qpgSht pyWduxltJ8VPQwRXdmr3QFP1YkNJbQQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-67-XEcrS6ocNgqNO8z32eTs8w-1; Tue, 10 Oct 2023 09:01:09 -0400 X-MC-Unique: XEcrS6ocNgqNO8z32eTs8w-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 95F0E85829A; Tue, 10 Oct 2023 13:01:08 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.49]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 46263492B04; Tue, 10 Oct 2023 13:01:07 +0000 (UTC) Date: Tue, 10 Oct 2023 14:01:04 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Alex =?utf-8?Q?Benn=C3=A9e?= Cc: Nicholas Piggin , qemu-ppc@nongnu.org, Cleber Rosa , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Wainer dos Santos Moschetta , Beraldo Leal , qemu-devel@nongnu.org Subject: Re: [RFC PATCH 07/11] tests/avocado: Add ppc boot tests for non-free AIX images Message-ID: References: <20231010075238.95646-1-npiggin@gmail.com> <20231010075238.95646-8-npiggin@gmail.com> <87h6mypryo.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87h6mypryo.fsf@linaro.org> User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Oct 10, 2023 at 01:43:16PM +0100, Alex Bennée wrote: > > Nicholas Piggin writes: > > > An AIX image can be provided by setting AIX_IMAGE environment > > variable when running avocado. > > > > It's questionable whether we should carry these in upstream QEMU. > > It's convenient to see how to run these things, but simple enough > > to maintain in out of tree branch. I just wanted to see opinions > > about it. > > Yeah there is no point adding a test no one else can run. We already > have tests that utilise dead URLs that can only run if you happen to > have the image in the avocado cache which should arguably be removed. I can understand the appeal of wanting to sanity check QEMU with esentially arbitrary guest OS, whether modern, or obsolete, whether OSS or proprietary. The appeal of getting the test integrated into QEMU is you don't have to worry about rebasing / merging local git changes forever more. I feel like this tells us we should not require users to be writing new avocado python test code merely to get a boring old guest OS boot up smoke test integrated into avocado. I think we ought to have a 'guest_smoke_test.py' avocado test, that pulls in guest OS scenarios from external YAML/JSON files. eg $ cat ppc_aix.yaml image: url: https:////some/path checksum: xxxxxx console: expect: ...some console message... vm: arch: ppc64 machine: pseries ....something something extra cli args something something... Users could then set export QEMU_SMOKE_TEST_PATHS=$HOME/my-guestos-library:$HOME/shared-guestos-library make check-avocado to load all the guest OS scenarios from these dirs, in addition to any scenarios that are shipped in qemu.git by default. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|