From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52E2ACD8CB4 for ; Tue, 10 Oct 2023 20:29:58 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qqJMK-0003Us-3z; Tue, 10 Oct 2023 16:29:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qqJMF-0003TT-Jl for qemu-devel@nongnu.org; Tue, 10 Oct 2023 16:29:36 -0400 Received: from mail-mw2nam10on2056.outbound.protection.outlook.com ([40.107.94.56] helo=NAM10-MW2-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qqJMC-0003y5-A2 for qemu-devel@nongnu.org; Tue, 10 Oct 2023 16:29:35 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JPyT78ODqkHuXSzDMvstG3CAxlWAkBqwpkjlNaA4MMbiA1rC+gzrKQwz+8LslnyxgoGCd/Ix1PXw9EJgOvVBfr7FVybrArsw64sNG8IGxmyxj51IHfoYpZZLc52EbXpzR47gujtxOZm3IiDNeTzXOhTJR+dYqLFMaCfXttKZ4zKTF8vsYuo2Y1Gcj7Uo26XMkq3AaMVE/kE2rbzw08MOABLPQOSeQDS7w73cAvzVbkoTQ+r+BVAblaNnqQlmXg0oZ2XxFalDcD42MJs+9s/Jsb/Nx8kwqs0tWKE5ywzEWKKnT5ZUwgdf72WGRWZntS83RSeW39yqH6m8xqOvABrxfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TW5M88XSPh2mnv64QH1pzCHi+mM6Ti+xuwwtjMt0qZE=; b=fl5Vcai/94MefbUKUI3ej7buR7UCFn4xRc1fjNzeEubV0GXgpw1O0wMv3rYc2hp9GTs3cG50EQkZeWAIHbx2cx1gYhMP3qmE1c137AABi/GT+I9k3eutmZd8TzG+27YmbmKGCLcQ0C6re9uXe+OsOZcZFZQux2b2cnkaktJbOjnlP4Hky6e2yq/IxLArrxQHWTEWlbjfR1vL2GSAwF5OuCgjbVL6NhB9XD7tGgufFgJpalUCPztcWg1bEgZ7UvuwTwLsnTw8V0FKP9WA/em3D6gzBMwxl3IA51/odO9VXdd+GOHkccRzpsM4lH6vzFNvzvfRqmI7Mba3EwunLKGA2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TW5M88XSPh2mnv64QH1pzCHi+mM6Ti+xuwwtjMt0qZE=; b=E7rISsO+3QxiIUkMMTr1oWeXSrvzmyxMaNT+U2+qU0tCYho5T9ljFz4XxvG/NH+iePHXfPms+qgSkoSJn7whmhO8/njWLaJhdf0ACVm8gDnrYiExYQVd1ORnjKj+jmOgRdfOEo/mMyp91SqNJ6o0XjNOz3vEnijfm9Xm1cx2gPg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from MW3PR12MB4409.namprd12.prod.outlook.com (2603:10b6:303:2d::23) by CYXPR12MB9442.namprd12.prod.outlook.com (2603:10b6:930:e3::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.36; Tue, 10 Oct 2023 20:24:23 +0000 Received: from MW3PR12MB4409.namprd12.prod.outlook.com ([fe80::7c95:99c7:7f5f:c24a]) by MW3PR12MB4409.namprd12.prod.outlook.com ([fe80::7c95:99c7:7f5f:c24a%4]) with mapi id 15.20.6863.032; Tue, 10 Oct 2023 20:24:23 +0000 Date: Tue, 10 Oct 2023 13:24:20 -0700 From: Vikram Garhwal To: Stefano Stabellini Cc: qemu-devel@nongnu.org, Juergen Gross , Anthony Perard , Paul Durrant , "Michael S. Tsirkin" , Marcel Apfelbaum , Paolo Bonzini , Richard Henderson , Eduardo Habkost , "open list:X86 Xen CPUs" Subject: Re: [QEMU][PATCH v1 1/7] xen: when unplugging emulated devices skip virtio devices Message-ID: References: <20231005181629.4046-1-vikram.garhwal@amd.com> <20231005181629.4046-2-vikram.garhwal@amd.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: BY5PR17CA0061.namprd17.prod.outlook.com (2603:10b6:a03:167::38) To MW3PR12MB4409.namprd12.prod.outlook.com (2603:10b6:303:2d::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW3PR12MB4409:EE_|CYXPR12MB9442:EE_ X-MS-Office365-Filtering-Correlation-Id: 66de529f-2770-4848-ab40-08dbc9cee424 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3D770+FAU5q7Eu7a9jt8Mr2rmxpOHIuZeLeK0D3tw/OVyOz7tqHN/krtgnHgKn43tgOkFkZRAopbqPwXlhW5tk40cT163stYjr00sQOMsvernxFxGiJKSByLPYzH5Xwoxb/R+PL6VJUoAKEYzK0xG/t/4cPnXm0xsEyP8Q7YgPRZB8xda5me+3t5XvEN+HjFv2aRcAFPV3+BDZjUX4iLaAYwjKa40ltdIMkjg5hTC05d8Vo5Vddk5SNx7IMimNcACcIjp5t1+DR1TivuigZ0MvcukcNXDlDnbGH9T/jcOi0xRuncrj0Skl3nCzFvVHyOD9nPIeJMZWEwDkR2wMaSgqYUrNNjAyq+m7o1sP8xYYThGfA3AMjGaI5XB/rf/IxOblkwfonZ40Q5Z/9OIQ35pcttVMfKK29T/ZU/IR/uMuR33+6Eo+2ylwk2puU4v2iGtg4b/kWs+n0JI7bMYAW0phoIjzsbs8CENKM2SFnePCMdvCJ39i9tooOImYZ+wWUMt4j1jmfmevRpbGU+wSBNwPCciygE809cVpS1zjVbAecgVrl47zF/N9QS/OLeqY3P X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW3PR12MB4409.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(366004)(346002)(376002)(136003)(39860400002)(230922051799003)(1800799009)(64100799003)(451199024)(186009)(26005)(2616005)(8936002)(6512007)(83380400001)(6506007)(8676002)(478600001)(7416002)(6486002)(2906002)(4326008)(5660300002)(54906003)(66556008)(41300700001)(66946007)(6916009)(44832011)(66476007)(316002)(86362001)(38100700002)(36756003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dThVUytMeG1VbkRXUFVHT1dTSXlpWFJWSUx6SlJUT09ITEpqRVZ6bEhmYkZu?= =?utf-8?B?MGlXQjVTeGZJaEJibWkwWXBuYWNOeXhnWjJlTWFYOVlzRWNhS3JGT3B6VDZC?= =?utf-8?B?Z3NaZ3NSd2FGQUFvN3h5NWl6RDh0K0Eva1AwVldEV3d0eDlKU1EzdUFnMmZl?= =?utf-8?B?dmJrY1NKODRMRmI0Y0RzenpRTC9meFo3b081cVRZd2RUbHlkTk9GbkNkeW51?= =?utf-8?B?L3lCaStWUEJqZXFCWG51b0Zmcm8zZWsydEJNelNXTkl1d2lWVXVTZk5jTFBs?= =?utf-8?B?Q0VaS2NQeGorN1hibTBRUmxFM28yUHhlWTFoT0h0dUJ1NWxBbXRka043VHNQ?= =?utf-8?B?OThoVXNSSmg0VGRLU3I1WTdPeE5XbVlKOTNrU3h5YVF2bGZRdldROUcvd3Za?= =?utf-8?B?bnBKWXhmL2tLdldGVzY4U2NxWHN4S1lScG4wRG5mYTRyRE9VRjAvRCt1Wko3?= =?utf-8?B?SVVkQVVyRDBqTDQ0cW1uMjlEMnhvWTNpU1F6czVsSXZVZk04T2hkMkg4Zk90?= =?utf-8?B?TWxnMUtZcjhQQXZDV3htMkpXVEJoSXZVTlJFNFV1NkNFaFo1Ym1MTDYzbHZ2?= =?utf-8?B?OE9qWk81TS90WVRGQnBWYlAwemRnR2VYaEt1L0JFSXNVMUlUTHcxWjUvSDEz?= =?utf-8?B?cVpwVTJTY1MveWZuQ3BXNUxUNW8wbEthcW54UkpJZ1NIMjhHOU5VaG9BZmpv?= =?utf-8?B?YjdmYlo0cmJtT1ZuUGI2K0doOUhQVnJKK3d3MnBqanBLenRPUk5oMlY3YUxZ?= =?utf-8?B?ZURDTE9SRzQ3RWxya3VzWkplMlJNdFpIOG9YenYydUp4TDF6MUcycU5YRjds?= =?utf-8?B?STJscW9MNFlwbnA2Y2ZyU2JWZEdmbmhDbmZhR0dNb29TcnFZYkNNZjNIcmEw?= =?utf-8?B?NnhXTFpDTGtLT2ZzWWU0N0R0RCtFZVVuNDk5dThHbG1xT1ZPaHJ4d2tmMWh1?= =?utf-8?B?VWZENmUxS25MTlpmR3RsOEwyUlpna0hDTjhFa2lXL0RTZnMrL09wK2xCWkU4?= =?utf-8?B?azRhZjNoMmM3cmZjN2JyWktlMS9kbEJxcjVHK01EYjNtT0pKQk41cmZOa1JF?= =?utf-8?B?ZU9KYW1rRGFtbU92UHUvMGVlT25kSWk4SHhyTWpRRWdiUy9FdkpNRzJUdmpa?= =?utf-8?B?SmxUUURnR1lRTnB5ejlxUGo2VXBxcWFnUWdXTlZTbFp2cW8wQXA5bHlVZUpQ?= =?utf-8?B?bDF5WGJTOVZQaXJBNHI3dENqL0RRM3M2eHBLTDY2dnoxa1cyTk1lWUNMOFlv?= =?utf-8?B?d1JNZkdNb0VkTzEvL2VnSVdSK0VoSnFvSjh4T09vdEpMM3ZkMEluOGNNU1Nr?= =?utf-8?B?cWlMd1kvOGJQdkVKU1U1ZnRKTVQwK0dSdXdrOWo5alBIV0w1T0V4RStOeml3?= =?utf-8?B?MlRWb2ZsSU9QTUYzVW1WVXZXVm12Rld2UEFrUkNiZk05SXZHUm5pNTZsTm5G?= =?utf-8?B?OTc2K0FCc2ljbWJRN2g4MGJOekZ6V0M5YUhRTHhHZVh3VytBQXdaazRja1o3?= =?utf-8?B?UGo5RHFJNklERytKKzU1c0hPK29UOGxZcWlWT1FYTmVId2QwK3l6UE5od3dI?= =?utf-8?B?VmIxdG1XMnZ6UE45NXZybWZodUtCVmk0ZG1rT3BPZDUyNGFOK1JxTFJFaFZO?= =?utf-8?B?Tko4ZloyenZJN0ZlaDNwT21hQXhLeVpLVUUwTW9NTzMzd0FSRDlTS0VjckFG?= =?utf-8?B?K2t2SGo5SFlsNEpwTWo5NHVJOXdEdFk1dFhGMSt3bWoyWXBBMEovcTZ6N3Q5?= =?utf-8?B?U1NsK290Q3R3TG5CQW9tcVAvcDVkRmVtQ1pURkt6T0hLNTZzSWpJQjQvTExH?= =?utf-8?B?V1hMY0VwWkhXZTBoczZ2cDFFRXZNRzZ6VDlQcGdwcVQwRjh5NVJYSWt1alZ1?= =?utf-8?B?TmhyU2lhS0ttNDQ3Q3ZmQUZGQ0hMamNPS3NmaHNpN1BsazZWOVJvVVNEbDZL?= =?utf-8?B?Mmpxd2pqWG55amFZejhXdVFoK09uT0VrQlBDcWJITkFLdUdKY0hKOHFkbVla?= =?utf-8?B?cmNHK3B5NTgwTzVwYUFLOEwzdVhQYWJGWm9pTWVsdTBSelpqZllvMTAvUlV2?= =?utf-8?B?MVVzd0I4ejhJdlpYNFpXNHd0VkNPZExBNEdVN1hoeWs4aWVLeGN4d1o5ZEZH?= =?utf-8?Q?mp57rHOObsF7vZJ//YSYsKOQa?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 66de529f-2770-4848-ab40-08dbc9cee424 X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4409.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2023 20:24:23.2688 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: P/uFlsUs5OZVV4+M15Q+MMSym7k0/CrB8NjesBwEhuz9dUuyxRAj0IqQ+/BhoEtjm68uF06fzGULi5NcdXr4Jw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYXPR12MB9442 Received-SPF: softfail client-ip=40.107.94.56; envelope-from=vikram.garhwal@amd.com; helo=NAM10-MW2-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Hi Stefano, On Mon, Oct 09, 2023 at 04:51:53PM -0700, Stefano Stabellini wrote: > On Thu, 5 Oct 2023, Vikram Garhwal wrote: > > From: Juergen Gross > > > > Virtio devices should never be unplugged at boot time, as they are > > similar to pci passthrough devices. > > > > Signed-off-by: Juergen Gross > > Signed-off-by: Vikram Garhwal > > --- > > hw/i386/xen/xen_platform.c | 8 +++++++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/hw/i386/xen/xen_platform.c b/hw/i386/xen/xen_platform.c > > index 17457ff3de..3560eaf8c8 100644 > > --- a/hw/i386/xen/xen_platform.c > > +++ b/hw/i386/xen/xen_platform.c > > @@ -28,6 +28,7 @@ > > #include "hw/ide/pci.h" > > #include "hw/pci/pci.h" > > #include "migration/vmstate.h" > > +#include "hw/virtio/virtio-bus.h" > > #include "net/net.h" > > #include "trace.h" > > #include "sysemu/xen.h" > > @@ -132,7 +133,8 @@ static void unplug_nic(PCIBus *b, PCIDevice *d, void *o) > > /* We have to ignore passthrough devices */ > > if (pci_get_word(d->config + PCI_CLASS_DEVICE) == > > PCI_CLASS_NETWORK_ETHERNET > > - && !pci_device_is_passthrough(d)) { > > + && !pci_device_is_passthrough(d) > > + && !qdev_get_child_bus(&d->qdev, TYPE_VIRTIO_BUS)) { > > Please update the in-code comment above to say "ignore passthrough > devices and virtio devices" Sounds good. Will update in the code comment in v2. > > > > object_unparent(OBJECT(d)); > > } > > } > > @@ -208,6 +210,10 @@ static void unplug_disks(PCIBus *b, PCIDevice *d, void *opaque) > > /* We have to ignore passthrough devices */ > > if (pci_device_is_passthrough(d)) > > return; > > + /* Ignore virtio devices */ > > + if (qdev_get_child_bus(&d->qdev, TYPE_VIRTIO_BUS)) { > > + return; > > + } > > > > switch (pci_get_word(d->config + PCI_CLASS_DEVICE)) { > > case PCI_CLASS_STORAGE_IDE: > > -- > > 2.17.1 > >