From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 83795CDB46E for ; Thu, 12 Oct 2023 07:15:43 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qqpuD-0005sp-Ef; Thu, 12 Oct 2023 03:14:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qqpuA-0005sc-UV for qemu-devel@nongnu.org; Thu, 12 Oct 2023 03:14:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qqpu7-0000J1-Rd for qemu-devel@nongnu.org; Thu, 12 Oct 2023 03:14:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697094882; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6Se6r8Aw0Ivbq9fRt2qpMfpa72D6Zk/nb4wUdnuPDFY=; b=I4Mz//t33Ph6k83lEL6lcwO38QqkqsFS3vCpkJv72DAPnemKwLhpAjmmRd/5nIU21EA6bW OqlEKy8PDxqVZUIb2HH3aXqcogAQ1wvc0izZOVS16yjArp+m1IbrSI4Q94KqOXkatc3K65 kX7CcAvbqpzuRNyIVAi3kVGT+4KRcHs= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-57-2MPN1oUfNYu3XicEKnaoOQ-1; Thu, 12 Oct 2023 03:14:29 -0400 X-MC-Unique: 2MPN1oUfNYu3XicEKnaoOQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9A2361C08963; Thu, 12 Oct 2023 07:14:28 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.32]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B6871111CD23; Thu, 12 Oct 2023 07:14:27 +0000 (UTC) Date: Thu, 12 Oct 2023 08:14:25 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Stefan Hajnoczi Cc: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Paolo Bonzini , Stefan Hajnoczi , qemu-devel@nongnu.org, Tyler Fanelli Subject: Re: [PULL 50/51] subprojects: add wrap file for libblkio Message-ID: References: <20230907130004.500601-1-pbonzini@redhat.com> <20230907130004.500601-51-pbonzini@redhat.com> <14ff27a8-284b-66f8-097a-5d49c94dcff8@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, Oct 11, 2023 at 04:58:01PM -0400, Stefan Hajnoczi wrote: > On Wed, 11 Oct 2023 at 04:48, Daniel P. Berrangé wrote: > > > > On Wed, Oct 11, 2023 at 07:35:24AM +0200, Philippe Mathieu-Daudé wrote: > > > Hi Paolo, > > > > > > On 7/9/23 14:59, Paolo Bonzini wrote: > > > > This allows building libblkio at the same time as QEMU, if QEMU is > > > > configured with --enable-blkio --enable-download. > > > > > > > > Signed-off-by: Paolo Bonzini > > > > --- > > > > subprojects/libblkio.wrap | 6 ++++++ > > > > 1 file changed, 6 insertions(+) > > > > create mode 100644 subprojects/libblkio.wrap > > > > > > > > diff --git a/subprojects/libblkio.wrap b/subprojects/libblkio.wrap > > > > new file mode 100644 > > > > index 00000000000..f77af72210c > > > > --- /dev/null > > > > +++ b/subprojects/libblkio.wrap > > > > @@ -0,0 +1,6 @@ > > > > +[wrap-git] > > > > +url = https://gitlab.com/libblkio/libblkio > > > > > > Tyler noticed this project isn't mirrored on QEMU gitlab namespace. > > > > Many other wraps aren't mirrored either, and I'm not convinced we > > need to, unless the project is on an obscure self hosted git service > > which is thought unreliable. > > What if upstream deletes the repository or sets visibility to > "private"? Do GitHub and GitLab guarantee availability of previously > public repositories? No, there's no such guarantee. If it was a repo under a personal user namespace mirroring is justified for this reason, but for a project level namespace I feel we're protecting ourselves from a scenario that's just never going to happen. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|