From: Peter Xu <peterx@redhat.com>
To: Fabiano Rosas <farosas@suse.de>
Cc: qemu-devel@nongnu.org, "Juan Quintela" <quintela@redhat.com>,
"Leonardo Bras" <leobras@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH v4 02/12] tests/qtest: Introduce qtest_init_with_env
Date: Wed, 18 Oct 2023 16:59:20 -0400 [thread overview]
Message-ID: <ZTBHKOwCy72Bu5CE@x1n> (raw)
In-Reply-To: <20231018192741.25885-3-farosas@suse.de>
On Wed, Oct 18, 2023 at 04:27:31PM -0300, Fabiano Rosas wrote:
> +/**
> + * qtest_init_with_env:
> + * @var: Environment variable from where to take the QEMU binary
> + * @extra_args: Other arguments to pass to QEMU. CAUTION: these
> + * arguments are subject to word splitting and shell evaluation.
> + *
> + * Like qtest_init(), but use a different environment variable for the
> + * QEMU binary.
> + *
> + * Returns: #QTestState instance.
> + */
> +QTestState *qtest_init_with_env(const char *var, const char *extra_args);
Another way to do is instead of passing over the env var, passing over
"char *qemu_bin" always, and take qtest_qemu_binary() as default. Also
relevant to patch 1. Not a big deal though, so can be done for later.
Thanks,
--
Peter Xu
next prev parent reply other threads:[~2023-10-18 21:00 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 19:27 [PATCH v4 00/12] tests/migration-test: Allow testing older machine types Fabiano Rosas
2023-10-18 19:27 ` [PATCH v4 01/12] tests/qtest: Allow qtest_qemu_binary to use a custom environment variable Fabiano Rosas
2023-10-18 19:27 ` [PATCH v4 02/12] tests/qtest: Introduce qtest_init_with_env Fabiano Rosas
2023-10-18 20:59 ` Peter Xu [this message]
2023-10-19 14:16 ` Fabiano Rosas
2023-10-18 19:27 ` [PATCH v4 03/12] tests/qtest: Allow qtest_get_machines to use an alternate QEMU binary Fabiano Rosas
2023-10-18 19:27 ` [PATCH v4 04/12] tests/qtest: Introduce qtest_has_machine_with_env Fabiano Rosas
2023-10-18 19:27 ` [PATCH v4 05/12] tests/qtest: Introduce qtest_resolve_machine_alias Fabiano Rosas
2023-10-18 19:27 ` [PATCH v4 06/12] tests/qtest/migration: Introduce find_common_machine_version Fabiano Rosas
2023-10-19 6:20 ` Thomas Huth
2023-10-18 19:27 ` [PATCH v4 07/12] tests/qtest/migration: Define a machine for all architectures Fabiano Rosas
2023-10-19 6:25 ` Thomas Huth
2023-10-19 8:07 ` Markus Armbruster
2023-10-19 11:57 ` Juan Quintela
2023-10-18 19:27 ` [PATCH v4 08/12] tests/qtest/migration: Specify the geometry of the bootsector Fabiano Rosas
2023-10-19 6:28 ` Thomas Huth
2023-10-19 11:59 ` Juan Quintela
2023-10-18 19:27 ` [PATCH v4 09/12] tests/qtest/migration: Set q35 as the default machine for x86_86 Fabiano Rosas
2023-10-19 6:28 ` Thomas Huth
2023-10-19 12:00 ` Juan Quintela
2023-10-18 19:27 ` [PATCH v4 10/12] tests/qtest/migration: Support more than one QEMU binary Fabiano Rosas
2023-10-19 6:46 ` Thomas Huth
2023-10-19 11:56 ` Juan Quintela
2023-10-19 14:06 ` Fabiano Rosas
2023-10-18 19:27 ` [PATCH v4 11/12] tests/qtest/migration: Allow user to specify a machine type Fabiano Rosas
2023-10-19 6:57 ` Thomas Huth
2023-10-19 12:06 ` Juan Quintela
2023-10-18 19:27 ` [PATCH v4 12/12] tests/qtest: Don't print messages from query instances Fabiano Rosas
2023-10-19 12:08 ` [PATCH v4 00/12] tests/migration-test: Allow testing older machine types Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTBHKOwCy72Bu5CE@x1n \
--to=peterx@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=farosas@suse.de \
--cc=leobras@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).