From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 817A0CDB465 for ; Thu, 19 Oct 2023 08:28:56 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qtOOW-0004YM-N0; Thu, 19 Oct 2023 04:28:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qtOOQ-0004XR-PJ for qemu-devel@nongnu.org; Thu, 19 Oct 2023 04:28:34 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qtOOP-0000Qs-4v for qemu-devel@nongnu.org; Thu, 19 Oct 2023 04:28:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697704112; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cyOQrlkmtEWk2Rw4BGDSL9kgufGXc/+aJHL9lbxL0s8=; b=KP7rNzrix2RNCyQc+pU6ukEewOCjneR8KIf/+shrIE/Pgy0PsNAkLgNl79lIfg9klx8Y/m MA7n0fECCFiKs1ujVz57kZHhbJIUso8784iVegL3i/DVv79t0JlFhDAVujqgFuDqhXGKRP +4CRZqRD3XqKJNpnZdcQtQ4XTceYX5o= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-646-NY4NCWI9M5ac7pcvjQS9Sg-1; Thu, 19 Oct 2023 04:28:27 -0400 X-MC-Unique: NY4NCWI9M5ac7pcvjQS9Sg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A17918115B1; Thu, 19 Oct 2023 08:28:26 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.60]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D02AE2166B26; Thu, 19 Oct 2023 08:28:24 +0000 (UTC) Date: Thu, 19 Oct 2023 09:28:22 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Ninad Palsule Cc: qemu-devel@nongnu.org, clg@kaod.org, peter.maydell@linaro.org, andrew@aj.id.au, joel@jms.id.au, pbonzini@redhat.com, marcandre.lureau@redhat.com, thuth@redhat.com, philmd@linaro.org, lvivier@redhat.com, qemu-arm@nongnu.org Subject: Re: [PATCH v5 04/10] hw/fsi: Introduce IBM's FSI Message-ID: References: <20231011151339.2782132-1-ninad@linux.ibm.com> <20231011151339.2782132-5-ninad@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231011151339.2782132-5-ninad@linux.ibm.com> User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, Oct 11, 2023 at 10:13:33AM -0500, Ninad Palsule wrote: > This is a part of patchset where IBM's Flexible Service Interface is > introduced. > > This commit models the FSI bus. CFAM is hanging out of FSI bus. The bus > is model such a way that it is embedded inside the FSI master which is a > bus controller. > > The FSI master: A controller in the platform service processor (e.g. > BMC) driving CFAM engine accesses into the POWER chip. At the > hardware level FSI is a bit-based protocol supporting synchronous and > DMA-driven accesses of engines in a CFAM. > > Signed-off-by: Andrew Jeffery > Signed-off-by: Cédric Le Goater > Signed-off-by: Ninad Palsule > Reviewed-by: Joel Stanley > --- > v2: > - Incorporated review comments by Joel > v5: > - Incorporated review comments by Cedric. > --- > include/hw/fsi/fsi-master.h | 30 ++++++ > include/hw/fsi/fsi.h | 37 +++++++ > hw/fsi/cfam.c | 2 +- > hw/fsi/fsi-master.c | 199 ++++++++++++++++++++++++++++++++++++ > hw/fsi/fsi.c | 54 ++++++++++ > hw/fsi/meson.build | 2 +- > hw/fsi/trace-events | 2 + > 7 files changed, 324 insertions(+), 2 deletions(-) > create mode 100644 include/hw/fsi/fsi-master.h > create mode 100644 include/hw/fsi/fsi.h > create mode 100644 hw/fsi/fsi-master.c > create mode 100644 hw/fsi/fsi.c > > +static void fsi_master_realize(DeviceState *dev, Error **errp) > +{ > + FSIMasterState *s = FSI_MASTER(dev); > + Error *err = NULL; > + > + qbus_init(&s->bus, sizeof(s->bus), TYPE_FSI_BUS, DEVICE(s), NULL); > + > + memory_region_init_io(&s->iomem, OBJECT(s), &fsi_master_ops, s, > + TYPE_FSI_MASTER, 0x10000000); > + memory_region_init(&s->opb2fsi, OBJECT(s), "fsi.opb2fsi", 0x10000000); > + > + object_property_set_bool(OBJECT(&s->bus), "realized", true, &err); > + if (err) { > + error_propagate(errp, err); > + return; > + } Redundant Error object, just check return value of set_bool > + > + memory_region_add_subregion(&s->opb2fsi, 0, &s->bus.slave.mr); > +} > +static void fsi_bus_realize(BusState *bus, Error **errp) > +{ > + FSIBus *s = FSI_BUS(bus); > + Error *err = NULL; > + > + /* Note: Move it elsewhere when we add more CFAMs. */ > + object_property_set_bool(OBJECT(&s->slave), "realized", true, &err); > + if (err) { > + error_propagate(errp, err); > + } Likewise. > +} > + With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|