* [PATCH] ipmi-bt-test: force ipv4
@ 2023-10-18 19:11 Vladimir Sementsov-Ogievskiy
2023-10-19 5:17 ` Thomas Huth
2023-10-19 18:30 ` Corey Minyard
0 siblings, 2 replies; 3+ messages in thread
From: Vladimir Sementsov-Ogievskiy @ 2023-10-18 19:11 UTC (permalink / raw)
To: qemu-devel
Cc: pbonzini, lvivier, thuth, minyard, yc-core, vsementsov,
den-plotnikov, daniil.tatianin
We open ipv4 listening socket. But "localhost" in qemu parameters may
load to Qemu trying to connect with ipv6 and fail with "Connection
refused". Force ipv4 by using ipv4 ip address.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
---
tests/qtest/ipmi-bt-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qtest/ipmi-bt-test.c b/tests/qtest/ipmi-bt-test.c
index ed431e34e6..383239bcd4 100644
--- a/tests/qtest/ipmi-bt-test.c
+++ b/tests/qtest/ipmi-bt-test.c
@@ -411,7 +411,7 @@ int main(int argc, char **argv)
g_test_init(&argc, &argv, NULL);
global_qtest = qtest_initf(
- " -chardev socket,id=ipmi0,host=localhost,port=%d,reconnect=10"
+ " -chardev socket,id=ipmi0,host=127.0.0.1,port=%d,reconnect=10"
" -device ipmi-bmc-extern,chardev=ipmi0,id=bmc0"
" -device isa-ipmi-bt,bmc=bmc0", emu_port);
qtest_irq_intercept_in(global_qtest, "ioapic");
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ipmi-bt-test: force ipv4
2023-10-18 19:11 [PATCH] ipmi-bt-test: force ipv4 Vladimir Sementsov-Ogievskiy
@ 2023-10-19 5:17 ` Thomas Huth
2023-10-19 18:30 ` Corey Minyard
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2023-10-19 5:17 UTC (permalink / raw)
To: Vladimir Sementsov-Ogievskiy, qemu-devel
Cc: pbonzini, lvivier, minyard, yc-core, den-plotnikov,
daniil.tatianin
On 18/10/2023 21.11, Vladimir Sementsov-Ogievskiy wrote:
> We open ipv4 listening socket. But "localhost" in qemu parameters may
> load to Qemu trying to connect with ipv6 and fail with "Connection
> refused". Force ipv4 by using ipv4 ip address.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
> ---
> tests/qtest/ipmi-bt-test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qtest/ipmi-bt-test.c b/tests/qtest/ipmi-bt-test.c
> index ed431e34e6..383239bcd4 100644
> --- a/tests/qtest/ipmi-bt-test.c
> +++ b/tests/qtest/ipmi-bt-test.c
> @@ -411,7 +411,7 @@ int main(int argc, char **argv)
> g_test_init(&argc, &argv, NULL);
>
> global_qtest = qtest_initf(
> - " -chardev socket,id=ipmi0,host=localhost,port=%d,reconnect=10"
> + " -chardev socket,id=ipmi0,host=127.0.0.1,port=%d,reconnect=10"
> " -device ipmi-bmc-extern,chardev=ipmi0,id=bmc0"
> " -device isa-ipmi-bt,bmc=bmc0", emu_port);
> qtest_irq_intercept_in(global_qtest, "ioapic");
Thanks, I'll queue it for my next pull request.
Acked-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ipmi-bt-test: force ipv4
2023-10-18 19:11 [PATCH] ipmi-bt-test: force ipv4 Vladimir Sementsov-Ogievskiy
2023-10-19 5:17 ` Thomas Huth
@ 2023-10-19 18:30 ` Corey Minyard
1 sibling, 0 replies; 3+ messages in thread
From: Corey Minyard @ 2023-10-19 18:30 UTC (permalink / raw)
To: Vladimir Sementsov-Ogievskiy
Cc: qemu-devel, pbonzini, lvivier, thuth, yc-core, den-plotnikov,
daniil.tatianin
On Wed, Oct 18, 2023 at 10:11:23PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> We open ipv4 listening socket. But "localhost" in qemu parameters may
> load to Qemu trying to connect with ipv6 and fail with "Connection
> refused". Force ipv4 by using ipv4 ip address.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
> ---
> tests/qtest/ipmi-bt-test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qtest/ipmi-bt-test.c b/tests/qtest/ipmi-bt-test.c
> index ed431e34e6..383239bcd4 100644
> --- a/tests/qtest/ipmi-bt-test.c
> +++ b/tests/qtest/ipmi-bt-test.c
> @@ -411,7 +411,7 @@ int main(int argc, char **argv)
> g_test_init(&argc, &argv, NULL);
>
> global_qtest = qtest_initf(
> - " -chardev socket,id=ipmi0,host=localhost,port=%d,reconnect=10"
> + " -chardev socket,id=ipmi0,host=127.0.0.1,port=%d,reconnect=10"
Yeah, this make sense.
Acked-by: Corey Minyard <cminyard@mvista.com>
> " -device ipmi-bmc-extern,chardev=ipmi0,id=bmc0"
> " -device isa-ipmi-bt,bmc=bmc0", emu_port);
> qtest_irq_intercept_in(global_qtest, "ioapic");
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-19 18:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-18 19:11 [PATCH] ipmi-bt-test: force ipv4 Vladimir Sementsov-Ogievskiy
2023-10-19 5:17 ` Thomas Huth
2023-10-19 18:30 ` Corey Minyard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).