From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Fabiano Rosas <farosas@suse.de>
Cc: qemu-devel@nongnu.org, prerna.saxena@nutanix.com,
dgilbert@redhat.com, pbonzini@redhat.com, armbru@redhat.com,
eblake@redhat.com, manish.mishra@nutanix.com,
aravind.retnakaran@nutanix.com, Het Gala <het.gala@nutanix.com>,
Juan Quintela <quintela@redhat.com>, Peter Xu <peterx@redhat.com>,
Leonardo Bras <leobras@redhat.com>
Subject: Re: [PATCH v14 10/14] fixup! migration: New migrate and migrate-incoming argument 'channels'
Date: Mon, 23 Oct 2023 12:54:33 +0100 [thread overview]
Message-ID: <ZTZe+Tw+D5S/4Mgd@redhat.com> (raw)
In-Reply-To: <20231019192353.31500-11-farosas@suse.de>
On Thu, Oct 19, 2023 at 04:23:49PM -0300, Fabiano Rosas wrote:
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
> ---
> qapi/migration.json | 8 ++++++++
> 1 file changed, 8 insertions(+)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
assuming you'll just squash into the previous patch
>
> diff --git a/qapi/migration.json b/qapi/migration.json
> index 85ad5f2601..f51e6663bb 100644
> --- a/qapi/migration.json
> +++ b/qapi/migration.json
> @@ -1666,6 +1666,14 @@
> # "port": "1050" } } ] } }
> # <- { "return": {} }
> #
> +# -> { "execute": "migrate",
> +# "arguments": {
> +# "channels": [ { "channel-type": "main",
> +# "addr": { "transport": "file",
> +# "path": "/tmp/migfile",
> +# "offset": "0x1000" } } ] } }
> +# <- { "return": {} }
> +#
> ##
> { 'command': 'migrate',
> 'data': {'*uri': 'str', '*channels': [ 'MigrationChannel' ],
> --
> 2.35.3
>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2023-10-23 11:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 19:23 [PATCH v14 00/14] migration: Modify 'migrate' and 'migrate-incoming' QAPI commands for migration Fabiano Rosas
2023-10-19 19:23 ` [PATCH v14 01/14] migration: New QAPI type 'MigrateAddress' Fabiano Rosas
2023-10-19 19:23 ` [PATCH v14 02/14] fixup! " Fabiano Rosas
2023-10-20 5:06 ` Markus Armbruster
2023-10-20 12:07 ` Fabiano Rosas
2023-10-20 12:37 ` Markus Armbruster
2023-10-20 13:31 ` Daniel P. Berrangé
2023-10-23 9:01 ` Should we replace QAPI? (was: [PATCH v14 02/14] fixup! migration: New QAPI type 'MigrateAddress') Markus Armbruster
2023-10-23 12:20 ` Daniel P. Berrangé
2023-10-23 11:56 ` [PATCH v14 02/14] fixup! migration: New QAPI type 'MigrateAddress' Daniel P. Berrangé
2023-10-19 19:23 ` [PATCH v14 03/14] migration: convert migration 'uri' into 'MigrateAddress' Fabiano Rosas
2023-10-19 19:23 ` [PATCH v14 04/14] fixup! " Fabiano Rosas
2023-10-23 11:55 ` Daniel P. Berrangé
2023-10-31 15:10 ` Juan Quintela
2023-10-19 19:23 ` [PATCH v14 05/14] migration: convert socket backend to accept MigrateAddress Fabiano Rosas
2023-10-19 19:23 ` [PATCH v14 06/14] migration: convert rdma " Fabiano Rosas
2023-10-19 19:23 ` [PATCH v14 07/14] migration: convert exec " Fabiano Rosas
2023-10-19 19:23 ` [PATCH v14 08/14] migration: Convert the file backend the new QAPI syntax Fabiano Rosas
2023-10-19 19:23 ` [PATCH v14 09/14] migration: New migrate and migrate-incoming argument 'channels' Fabiano Rosas
2023-10-19 19:23 ` [PATCH v14 10/14] fixup! " Fabiano Rosas
2023-10-23 11:54 ` Daniel P. Berrangé [this message]
2023-10-19 19:23 ` [PATCH v14 11/14] migration: modify migration_channels_and_uri_compatible() for new QAPI syntax Fabiano Rosas
2023-10-19 19:23 ` [PATCH v14 12/14] migration: Implement MigrateChannelList to qmp migration flow Fabiano Rosas
2023-10-19 19:23 ` [PATCH v14 13/14] migration: Implement MigrateChannelList to hmp " Fabiano Rosas
2023-10-19 19:23 ` [PATCH v14 14/14] migration: modify test_multifd_tcp_none() to use new QAPI syntax Fabiano Rosas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTZe+Tw+D5S/4Mgd@redhat.com \
--to=berrange@redhat.com \
--cc=aravind.retnakaran@nutanix.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=farosas@suse.de \
--cc=het.gala@nutanix.com \
--cc=leobras@redhat.com \
--cc=manish.mishra@nutanix.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=prerna.saxena@nutanix.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).