From: Corey Minyard <minyard@acm.org>
To: Juan Quintela <quintela@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH] hw/ipmi: Don't call vmstate_register() from instance_init() functions
Date: Mon, 23 Oct 2023 07:53:25 -0500 [thread overview]
Message-ID: <ZTZsxfUm+ECJMpB4@mail.minyard.net> (raw)
In-Reply-To: <87pm15shj2.fsf@secure.mitica>
On Mon, Oct 23, 2023 at 01:30:09PM +0200, Juan Quintela wrote:
> Thomas Huth <thuth@redhat.com> wrote:
> > instance_init() can be called multiple times, e.g. during introspection
> > of the device. We should not install the vmstate handlers here. Do it
> > in the realize() function instead.
> >
> > Signed-off-by: Thomas Huth <thuth@redhat.com>
>
> Reviewed-by: Juan Quintela <quintela@redhat.com>
>
> It fixes my issues.
>
> Should I take this through the Migration tree?
That's fine with me.
Acked-by: Corey Minyard <cminyard@mvista.com>
>
prev parent reply other threads:[~2023-10-23 12:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 14:55 [PATCH] hw/ipmi: Don't call vmstate_register() from instance_init() functions Thomas Huth
2023-10-23 11:30 ` Juan Quintela
2023-10-23 12:53 ` Corey Minyard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTZsxfUm+ECJMpB4@mail.minyard.net \
--to=minyard@acm.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).