From: Peter Xu <peterx@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, Zhijian Li <lizhijian@fujitsu.com>,
Markus Armbruster <armbru@redhat.com>,
Juan Quintela <quintela@redhat.com>,
Fabiano Rosas <farosas@suse.de>
Subject: Re: [PATCH] migration: Stop migration immediately in RDMA error paths
Date: Tue, 24 Oct 2023 11:58:32 -0400 [thread overview]
Message-ID: <ZTfpqDntHPoYIKFh@x1n> (raw)
In-Reply-To: <d4624b9a-ca5c-4576-b86e-a5290de7a81e@redhat.com>
On Tue, Oct 24, 2023 at 05:40:09PM +0200, Thomas Huth wrote:
> > @@ -3240,9 +3242,10 @@ static int ram_save_complete(QEMUFile *f, void *opaque)
> > ram_flush_compressed_data(rs);
> > - rdma_reg_ret = rdma_registration_stop(f, RAM_CONTROL_FINISH);
> > - if (rdma_reg_ret < 0) {
> > + ret = rdma_registration_stop(f, RAM_CONTROL_FINISH);
> > + if (ret < 0) {
> > qemu_file_set_error(f, rdma_reg_ret);
>
> I think you have to replace rdma_reg_ret here with ret again?
Yeah.. v2 was sent already, sorry for the noise.
--
Peter Xu
prev parent reply other threads:[~2023-10-24 15:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 15:33 [PATCH] migration: Stop migration immediately in RDMA error paths Peter Xu
2023-10-24 15:40 ` Thomas Huth
2023-10-24 15:58 ` Peter Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTfpqDntHPoYIKFh@x1n \
--to=peterx@redhat.com \
--cc=armbru@redhat.com \
--cc=farosas@suse.de \
--cc=lizhijian@fujitsu.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).