From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A7558C4332F for ; Fri, 10 Nov 2023 09:24:49 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r1Nke-000793-L4; Fri, 10 Nov 2023 04:24:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r1Nkc-00078n-Pv for qemu-devel@nongnu.org; Fri, 10 Nov 2023 04:24:30 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r1Nkb-0003yg-2k for qemu-devel@nongnu.org; Fri, 10 Nov 2023 04:24:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699608268; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=WtKDZkfabbXeQ8XuvS+m9fyTSOQiQupkxlF7xCLj/wY=; b=COgvo2EWYIy/BDNCnSnOkYiELt/p1aEM5qI0TlGJPVkQBgVM8bdu2bUH8t9mlToNrcOrDT hlIm0WPTqxH8fTBu3D1GwBTzvwh3ZUusy18OsTBNfESC4rJzBbbIMSIWDx2r4mHVw2xHQR 1WZ5Ij5WPdv1b4SxjUu8rr8LAZCZtUs= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-275-XM0GWF-PMOKEQPjuT1xe7w-1; Fri, 10 Nov 2023 04:24:26 -0500 X-MC-Unique: XM0GWF-PMOKEQPjuT1xe7w-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5E329101A550; Fri, 10 Nov 2023 09:24:26 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.89]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B12D540C6EB9; Fri, 10 Nov 2023 09:24:25 +0000 (UTC) Date: Fri, 10 Nov 2023 09:24:23 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Manos Pitsidianakis Cc: qemu-devel@nongnu.org, Paolo Bonzini , Peter Maydell Subject: Re: [PATCH 1/2] Add QEMU_WARN_UNUSED_RESULT attribute Message-ID: References: <84781fce2c3145a86d043d4c6b3b463af40eeed0.1699606819.git.manos.pitsidianakis@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <84781fce2c3145a86d043d4c6b3b463af40eeed0.1699606819.git.manos.pitsidianakis@linaro.org> User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, Nov 10, 2023 at 11:16:38AM +0200, Manos Pitsidianakis wrote: > This commit adds QEMU_WARN_UNUSED_RESULT, a macro for the gcc function > attribute `warn_unused_result`. The utility of this attribute is to > ensure functions that return values that need to be inspected are not > ignored by the caller. > > Signed-off-by: Manos Pitsidianakis > --- > include/qemu/compiler.h | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/include/qemu/compiler.h b/include/qemu/compiler.h > index c797f0d457..7ddbf1f1cf 100644 > --- a/include/qemu/compiler.h > +++ b/include/qemu/compiler.h > @@ -212,6 +212,20 @@ > # define QEMU_USED > #endif > > +/* > + * From GCC documentation: > + * > + * The warn_unused_result attribute causes a warning to be emitted if a > + * caller of the function with this attribute does not use its return value. > + * This is useful for functions where not checking the result is either a > + * security problem or always a bug, such as realloc. > + */ > +#if __has_attribute(warn_unused_result) > +# define QEMU_WARN_UNUSED_RESULT __attribute__((warn_unused_result)) > +#else > +# define QEMU_WARN_UNUSED_RESULT > +#endif GLib already provides us G_GNUC_WARN_UNUSED_RESULT so don't add this. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|