From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1862C4332F for ; Fri, 10 Nov 2023 11:23:51 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r1PbZ-0001Y5-3G; Fri, 10 Nov 2023 06:23:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r1PbW-0001XQ-9q for qemu-devel@nongnu.org; Fri, 10 Nov 2023 06:23:14 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r1PbT-0004f2-Qf for qemu-devel@nongnu.org; Fri, 10 Nov 2023 06:23:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699615391; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=NRO+hd2Nknho3S+fm83jWhO2LsuVoVb02z+etBZJKTQ=; b=fKZuBKIy9lPszIe5e1vqoC3AfJFD2JGs1E8+ZI6jhx3vSt0l+LVq25AJX3UzFSgtJnBrw/ pPlMF8JCwSVf9+INetgp5iont5D/fwxvYhTghjh3kWXu9eK131jvvCke8czrDo4yeNUMFI eLm3HdJ4hRCjrsYfrubAtThgfd94X4Q= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-473-_DCir9vkOc20SdmmGzI_NA-1; Fri, 10 Nov 2023 06:23:07 -0500 X-MC-Unique: _DCir9vkOc20SdmmGzI_NA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6287985A58B; Fri, 10 Nov 2023 11:23:07 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.89]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1E6F9502A; Fri, 10 Nov 2023 11:23:05 +0000 (UTC) Date: Fri, 10 Nov 2023 11:23:04 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Peter Maydell Cc: Manos Pitsidianakis , qemu-devel@nongnu.org, Paolo Bonzini , Gerd Hoffmann , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , qemu-arm@nongnu.org Subject: Re: [PATCH 2/2] Add warn_unused_result attr to AUD_register_card Message-ID: References: <4b040fc18cb0e563e92ce084ca18b89a050a8aaa.1699606819.git.manos.pitsidianakis@linaro.org> <3wmne.fhuf28sb5yfg@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, Nov 10, 2023 at 11:18:39AM +0000, Peter Maydell wrote: > On Fri, 10 Nov 2023 at 11:02, Manos Pitsidianakis > wrote: > > > > On Fri, 10 Nov 2023 12:21, Peter Maydell wrote: > > >This kind of thing is why Coverity's unused-result warning has a > > >lot of false positives. We shouldn't introduce extra code like > > >this to work around the fact that the tooling doesn't understand > > >our error-handling convention (i.e. error_fatal, and the way > > >that some functions report errors both via the return value and > > >also via the Error** argument). > > > > I respect that :). But I personally believe that clinging to C's > > inadequacies, instead of preventing bugs statically just because it adds > > some lines of code, is misguided. Proper code should strive to make bugs > > impossible in the first place. > > I generally agree. The problem here really is that we've ended > up with this odd API convention that reports errors in two > ways. In an ideal world we'd tidy up our APIs to report errors > exactly in one way (presumably via the Error). The compelling thing about our slightly odd &error_fatal/error_abort approach is that we can directly get stack traces showing exactly where the error happened. If we just propagate the error up the stack to finally exit/abort, the origin context is essentially lost, and when it does abort, we don't get a snapshot of all threads at the time the error hit, as we've moved on in time. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|