From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>
Subject: Re: [PATCH] audio: don't abort on f32 audio format in wav backend
Date: Tue, 7 Nov 2023 14:39:02 +0000 [thread overview]
Message-ID: <ZUpMBgRFblvJE1Z8@redhat.com> (raw)
In-Reply-To: <20230922151858.263447-1-berrange@redhat.com>
Ping, for anyone to review this trivial patch....
On Fri, Sep 22, 2023 at 04:18:58PM +0100, Daniel P. Berrangé wrote:
> Print a debug message as is done for other unsupported audio formats
> to give the user the chance to understand their mistake.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> audio/wavaudio.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/audio/wavaudio.c b/audio/wavaudio.c
> index 6445a2cb90..e70e5ee0c3 100644
> --- a/audio/wavaudio.c
> +++ b/audio/wavaudio.c
> @@ -97,6 +97,10 @@ static int wav_init_out(HWVoiceOut *hw, struct audsettings *as,
> dolog ("WAVE files can not handle 32bit formats\n");
> return -1;
>
> + case AUDIO_FORMAT_F32:
> + dolog("WAVE files can not handle float formats\n");
> + return -1;
> +
> default:
> abort();
> }
> --
> 2.41.0
>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2023-11-07 14:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 15:18 [PATCH] audio: don't abort on f32 audio format in wav backend Daniel P. Berrangé
2023-11-07 14:39 ` Daniel P. Berrangé [this message]
2023-11-07 14:53 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUpMBgRFblvJE1Z8@redhat.com \
--to=berrange@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).