* [PATCH] audio: don't abort on f32 audio format in wav backend
@ 2023-09-22 15:18 Daniel P. Berrangé
2023-11-07 14:39 ` Daniel P. Berrangé
2023-11-07 14:53 ` Marc-André Lureau
0 siblings, 2 replies; 3+ messages in thread
From: Daniel P. Berrangé @ 2023-09-22 15:18 UTC (permalink / raw)
To: qemu-devel; +Cc: Marc-André Lureau, Gerd Hoffmann, Daniel P. Berrangé
Print a debug message as is done for other unsupported audio formats
to give the user the chance to understand their mistake.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
audio/wavaudio.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/audio/wavaudio.c b/audio/wavaudio.c
index 6445a2cb90..e70e5ee0c3 100644
--- a/audio/wavaudio.c
+++ b/audio/wavaudio.c
@@ -97,6 +97,10 @@ static int wav_init_out(HWVoiceOut *hw, struct audsettings *as,
dolog ("WAVE files can not handle 32bit formats\n");
return -1;
+ case AUDIO_FORMAT_F32:
+ dolog("WAVE files can not handle float formats\n");
+ return -1;
+
default:
abort();
}
--
2.41.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] audio: don't abort on f32 audio format in wav backend
2023-09-22 15:18 [PATCH] audio: don't abort on f32 audio format in wav backend Daniel P. Berrangé
@ 2023-11-07 14:39 ` Daniel P. Berrangé
2023-11-07 14:53 ` Marc-André Lureau
1 sibling, 0 replies; 3+ messages in thread
From: Daniel P. Berrangé @ 2023-11-07 14:39 UTC (permalink / raw)
To: qemu-devel; +Cc: Marc-André Lureau, Gerd Hoffmann
Ping, for anyone to review this trivial patch....
On Fri, Sep 22, 2023 at 04:18:58PM +0100, Daniel P. Berrangé wrote:
> Print a debug message as is done for other unsupported audio formats
> to give the user the chance to understand their mistake.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> audio/wavaudio.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/audio/wavaudio.c b/audio/wavaudio.c
> index 6445a2cb90..e70e5ee0c3 100644
> --- a/audio/wavaudio.c
> +++ b/audio/wavaudio.c
> @@ -97,6 +97,10 @@ static int wav_init_out(HWVoiceOut *hw, struct audsettings *as,
> dolog ("WAVE files can not handle 32bit formats\n");
> return -1;
>
> + case AUDIO_FORMAT_F32:
> + dolog("WAVE files can not handle float formats\n");
> + return -1;
> +
> default:
> abort();
> }
> --
> 2.41.0
>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] audio: don't abort on f32 audio format in wav backend
2023-09-22 15:18 [PATCH] audio: don't abort on f32 audio format in wav backend Daniel P. Berrangé
2023-11-07 14:39 ` Daniel P. Berrangé
@ 2023-11-07 14:53 ` Marc-André Lureau
1 sibling, 0 replies; 3+ messages in thread
From: Marc-André Lureau @ 2023-11-07 14:53 UTC (permalink / raw)
To: Daniel P. Berrangé; +Cc: qemu-devel, Gerd Hoffmann
On Fri, Sep 22, 2023 at 7:19 PM Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> Print a debug message as is done for other unsupported audio formats
> to give the user the chance to understand their mistake.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> audio/wavaudio.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/audio/wavaudio.c b/audio/wavaudio.c
> index 6445a2cb90..e70e5ee0c3 100644
> --- a/audio/wavaudio.c
> +++ b/audio/wavaudio.c
> @@ -97,6 +97,10 @@ static int wav_init_out(HWVoiceOut *hw, struct audsettings *as,
> dolog ("WAVE files can not handle 32bit formats\n");
> return -1;
>
> + case AUDIO_FORMAT_F32:
> + dolog("WAVE files can not handle float formats\n");
> + return -1;
> +
> default:
> abort();
> }
> --
> 2.41.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-07 14:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-22 15:18 [PATCH] audio: don't abort on f32 audio format in wav backend Daniel P. Berrangé
2023-11-07 14:39 ` Daniel P. Berrangé
2023-11-07 14:53 ` Marc-André Lureau
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).