From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, thuth@redhat.com, alistair@alistair23.me,
edgar.iglesias@gmail.com, peter.maydell@linaro.org,
francisco.iglesias@amd.com, qemu-arm@nongnu.org
Subject: Re: [PATCH 0/2] Replace anti-social QOM type names (again)
Date: Mon, 13 Nov 2023 13:47:08 +0000 [thread overview]
Message-ID: <ZVIo3FsmwpfHzsh8@redhat.com> (raw)
In-Reply-To: <20231113134344.1195478-1-armbru@redhat.com>
On Mon, Nov 13, 2023 at 02:43:42PM +0100, Markus Armbruster wrote:
> We got rid of QOM type names containing ',' in 6.0, but some have
> crept back in. Replace them just like we did in 6.0.
It is practical to add
assert(strchr(name, ',') == NULL)
to some place in QOM to stop them coming back yet again ?
>
> Cover letter of 6.0's replacement:
> https://lore.kernel.org/qemu-devel/20210304140229.575481-1-armbru@redhat.com/
>
> Markus Armbruster (2):
> docs/system/arm: Fix for rename of type "xlnx.bbram-ctrl"
> hw: Replace anti-social QOM type names (again)
>
> docs/system/arm/xlnx-versal-virt.rst | 4 ++--
> include/hw/misc/xlnx-versal-cframe-reg.h | 2 +-
> include/hw/misc/xlnx-versal-cfu.h | 6 +++---
> include/hw/misc/xlnx-versal-crl.h | 2 +-
> include/hw/nvram/xlnx-efuse.h | 2 +-
> include/hw/nvram/xlnx-versal-efuse.h | 4 ++--
> include/hw/nvram/xlnx-zynqmp-efuse.h | 2 +-
> 7 files changed, 11 insertions(+), 11 deletions(-)
>
> --
> 2.41.0
>
>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2023-11-13 13:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 13:43 [PATCH 0/2] Replace anti-social QOM type names (again) Markus Armbruster
2023-11-13 13:43 ` [PATCH 1/2] docs/system/arm: Fix for rename of type "xlnx.bbram-ctrl" Markus Armbruster
2023-11-13 14:00 ` Francisco Iglesias
2023-11-13 14:50 ` Philippe Mathieu-Daudé
2023-11-13 15:54 ` Thomas Huth
2023-11-13 16:22 ` Markus Armbruster
2023-11-13 13:43 ` [PATCH 2/2] hw: Replace anti-social QOM type names (again) Markus Armbruster
2023-11-13 14:13 ` Francisco Iglesias
2023-11-13 16:06 ` Thomas Huth
2023-11-13 13:47 ` Daniel P. Berrangé [this message]
2023-11-14 7:41 ` [PATCH 0/2] " Markus Armbruster
2023-11-14 8:06 ` Thomas Huth
2023-11-14 9:51 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZVIo3FsmwpfHzsh8@redhat.com \
--to=berrange@redhat.com \
--cc=alistair@alistair23.me \
--cc=armbru@redhat.com \
--cc=edgar.iglesias@gmail.com \
--cc=francisco.iglesias@amd.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).