From: Peter Xu <peterx@redhat.com>
To: Zongmin Zhou <zhouzongmin@kylinos.cn>
Cc: quintela@redhat.com, berrange@redhat.com, farosas@suse.de,
leobras@redhat.com, qemu-devel@nongnu.org
Subject: Re: [PATCH v2] migration: free 'saddr' since be no longer used
Date: Fri, 17 Nov 2023 08:56:13 -0500 [thread overview]
Message-ID: <ZVdw_XMJ4mKMFejd@x1n> (raw)
In-Reply-To: <6dab8a5d-4982-41b6-92a0-f06c561969c3@kylinos.cn>
On Fri, Nov 17, 2023 at 10:51:18AM +0800, Zongmin Zhou wrote:
> > As Peter said, putting a comment why we don't use
> > qapi_free_SocketAddress() will be a good idea.
>
> I have put some comments on patch v2 to explain
Normally we use "comment" to represent direct comment in the code. You
explained it in the "commit message". :)
That explanation is good enough to me, you can add a summary comment in the
code too. Something like:
/* Don't free the objects inside; their ownership moved to "addr" */
--
Peter Xu
next prev parent reply other threads:[~2023-11-17 13:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-15 3:27 [PATCH] migration: free 'saddr' since be no longer used Zongmin Zhou
2023-11-15 9:49 ` Daniel P. Berrangé
2023-11-15 16:44 ` Peter Xu
2023-11-16 6:34 ` [PATCH v2] " Zongmin Zhou
2023-11-16 14:19 ` Juan Quintela
2023-11-17 2:51 ` Zongmin Zhou
2023-11-17 13:56 ` Peter Xu [this message]
2023-11-20 3:14 ` [PATCH v3] " Zongmin Zhou
2023-11-20 9:08 ` Daniel P. Berrangé
2023-11-20 14:01 ` Peter Xu
2023-11-29 2:09 ` Zongmin Zhou
2023-11-29 14:47 ` Peter Xu
2023-11-30 10:20 ` Het Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZVdw_XMJ4mKMFejd@x1n \
--to=peterx@redhat.com \
--cc=berrange@redhat.com \
--cc=farosas@suse.de \
--cc=leobras@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=zhouzongmin@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).