From: Kevin Wolf <kwolf@redhat.com>
To: Fam <fam@euphon.net>
Cc: qemu-devel@nongnu.org, Hanna Reitz <hreitz@redhat.com>,
qemu-block@nongnu.org
Subject: Re: [PATCH] vmdk: Don't corrupt desc file in vmdk_write_cid
Date: Mon, 27 Nov 2023 17:06:25 +0100 [thread overview]
Message-ID: <ZWS-gcue2egLkFQA@redhat.com> (raw)
In-Reply-To: <20231124115654.3239137-1-fam@euphon.net>
Am 24.11.2023 um 12:56 hat Fam geschrieben:
> From: Fam Zheng <fam@euphon.net>
>
> If the text description file is larger than DESC_SIZE, we force the last
> byte in the buffer to be 0 and write it out.
>
> This results in a corruption.
>
> Try to allocate a big buffer in this case.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1923
>
> Signed-off-by: Fam Zheng <fam@euphon.net>
Thanks, applied to the block branch.
But while I'm looking at this function, is there really anything that
guarantees that "parentCID" always exists and comes immediately after
"CID"? This looks like a questionable assumption to me.
Kevin
prev parent reply other threads:[~2023-11-27 16:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-24 11:56 [PATCH] vmdk: Don't corrupt desc file in vmdk_write_cid Fam
2023-11-27 15:18 ` Eric Blake
2023-11-27 18:23 ` Kevin Wolf
2023-11-27 16:06 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZWS-gcue2egLkFQA@redhat.com \
--to=kwolf@redhat.com \
--cc=fam@euphon.net \
--cc=hreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).