From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 777A6C4167B for ; Mon, 27 Nov 2023 16:06:49 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r7e82-0004Jd-E5; Mon, 27 Nov 2023 11:06:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r7e81-0004J0-3j for qemu-devel@nongnu.org; Mon, 27 Nov 2023 11:06:33 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r7e7z-0001nD-FV for qemu-devel@nongnu.org; Mon, 27 Nov 2023 11:06:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701101189; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RIiePH4EJ4dUIpbico6j1+8MDhOpqasC3Pzi+CE1FMw=; b=ix1UYKS2pnSWHSaS33qYCfvmaPjvxB+6LMcs67tr79LTZde+ev9ZwpVA2qHWLiHHwnY34J KELuEo2vkNR9bcFXS1lCqGYz8coidOPkz+q08uzzUQOMutBiQM/qkL8ZZGco293XF6Tx/y G0AOEXcSBSzsBBTDa/RP0jo3JSH7xYU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-474-vILySTAbOJ-7mE8updkRdw-1; Mon, 27 Nov 2023 11:06:27 -0500 X-MC-Unique: vILySTAbOJ-7mE8updkRdw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E8419101A52D; Mon, 27 Nov 2023 16:06:26 +0000 (UTC) Received: from redhat.com (unknown [10.39.194.177]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3FDAF1121307; Mon, 27 Nov 2023 16:06:26 +0000 (UTC) Date: Mon, 27 Nov 2023 17:06:25 +0100 From: Kevin Wolf To: Fam Cc: qemu-devel@nongnu.org, Hanna Reitz , qemu-block@nongnu.org Subject: Re: [PATCH] vmdk: Don't corrupt desc file in vmdk_write_cid Message-ID: References: <20231124115654.3239137-1-fam@euphon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231124115654.3239137-1-fam@euphon.net> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 Received-SPF: pass client-ip=170.10.133.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Am 24.11.2023 um 12:56 hat Fam geschrieben: > From: Fam Zheng > > If the text description file is larger than DESC_SIZE, we force the last > byte in the buffer to be 0 and write it out. > > This results in a corruption. > > Try to allocate a big buffer in this case. > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1923 > > Signed-off-by: Fam Zheng Thanks, applied to the block branch. But while I'm looking at this function, is there really anything that guarantees that "parentCID" always exists and comes immediately after "CID"? This looks like a questionable assumption to me. Kevin