From: Kevin Wolf <kwolf@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: Fam <fam@euphon.net>,
qemu-devel@nongnu.org, Hanna Reitz <hreitz@redhat.com>,
qemu-block@nongnu.org
Subject: Re: [PATCH] vmdk: Don't corrupt desc file in vmdk_write_cid
Date: Mon, 27 Nov 2023 19:23:30 +0100 [thread overview]
Message-ID: <ZWTeohXgdEsb6ufx@redhat.com> (raw)
In-Reply-To: <d7ktomuufu2yrhqlqfuqllllbrzsyzmpup53q7rn5ybal6et4v@tf4ovvmqszfx>
Am 27.11.2023 um 16:18 hat Eric Blake geschrieben:
> On Fri, Nov 24, 2023 at 11:56:54AM +0000, Fam wrote:
> > From: Fam Zheng <fam@euphon.net>
> >
> > If the text description file is larger than DESC_SIZE, we force the last
> > byte in the buffer to be 0 and write it out.
> >
> > This results in a corruption.
> >
> > Try to allocate a big buffer in this case.
> >
> > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1923
> >
> > Signed-off-by: Fam Zheng <fam@euphon.net>
> > ---
> > block/vmdk.c | 28 ++++++++++++++++++++--------
> > tests/qemu-iotests/059 | 2 ++
> > tests/qemu-iotests/059.out | 4 ++++
> > 3 files changed, 26 insertions(+), 8 deletions(-)
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
>
> Are we trying to get this into 8.2, since it is a data corruption?
Yes, I've queued it for -rc2.
Kevin
next prev parent reply other threads:[~2023-11-27 18:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-24 11:56 [PATCH] vmdk: Don't corrupt desc file in vmdk_write_cid Fam
2023-11-27 15:18 ` Eric Blake
2023-11-27 18:23 ` Kevin Wolf [this message]
2023-11-27 16:06 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZWTeohXgdEsb6ufx@redhat.com \
--to=kwolf@redhat.com \
--cc=eblake@redhat.com \
--cc=fam@euphon.net \
--cc=hreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).