From: Peter Xu <peterx@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Het Gala <het.gala@nutanix.com>,
qemu-devel@nongnu.org, prerna.saxena@nutanix.com,
quintela@redhat.com, berrange@redhat.com,
peter.maydell@linaro.org, farosas@suse.de
Subject: Re: [PATCH v4] migration: Plug memory leak with migration URIs
Date: Fri, 1 Dec 2023 10:29:45 -0500 [thread overview]
Message-ID: <ZWn76Vtj7L_XBS6O@x1n> (raw)
In-Reply-To: <87y1ee1m2m.fsf@pond.sub.org>
On Fri, Dec 01, 2023 at 07:19:45AM +0100, Markus Armbruster wrote:
> I meant the first visible case, i.e. if (channels). Sorry for being
> less than clear!
>
> The problem is to free the result of migrate_uri_parse().
>
> The patch's solution is to use @channel *only* for holding that result,
> so it can be g_autoptr: drop channel = channels->value from the if
> (channels) conditional.
>
> Since this breaks addr = channel->addr, we move that assignment into the
> conditionals that reach it, which lets us unbreak it the if (channels)
> one.
My bad! It also proved that my R-b was bold. :( Thanks, Markus.
Since Juan's away, I'll prepare a pull.
--
Peter Xu
prev parent reply other threads:[~2023-12-01 15:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 20:43 [PATCH v4] migration: Plug memory leak with migration URIs Het Gala
2023-11-30 7:21 ` Markus Armbruster
2023-11-30 17:29 ` Peter Xu
2023-11-30 18:35 ` Markus Armbruster
2023-11-30 19:16 ` Peter Xu
2023-12-01 6:19 ` Markus Armbruster
2023-12-01 15:29 ` Peter Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZWn76Vtj7L_XBS6O@x1n \
--to=peterx@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=farosas@suse.de \
--cc=het.gala@nutanix.com \
--cc=peter.maydell@linaro.org \
--cc=prerna.saxena@nutanix.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).