From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7F7BBC07E97 for ; Fri, 1 Dec 2023 16:38:54 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r96XR-0006xH-Hk; Fri, 01 Dec 2023 11:38:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r96XN-0006wu-SI for qemu-devel@nongnu.org; Fri, 01 Dec 2023 11:38:45 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r96XM-0006Sm-Cq for qemu-devel@nongnu.org; Fri, 01 Dec 2023 11:38:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701448723; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+CNJf5z4TeVRda7Ixo+sKYGlI9lNTzq/Y6FEjBHfNjo=; b=eSWBOBtLBaqbSx8UdnCR9Z2ZZ3xWUhk3lcVsgS5auEqd2Z5iLhmf7PwTQpUw65fMpfogVg ktrXjEp5vLlI0KuoJvqBhQK/BvxHyJNOHSCJi7d4iKGaND5qxgJJlFo1ulVihk7/pJkfIK Jx3Omrfm6A6rBhyo4UwZbfBonEZwkCs= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-136-nGbMR_C3MlGA521ialvzqw-1; Fri, 01 Dec 2023 11:38:42 -0500 X-MC-Unique: nGbMR_C3MlGA521ialvzqw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F2FC9185A783; Fri, 1 Dec 2023 16:38:41 +0000 (UTC) Received: from redhat.com (unknown [10.39.194.98]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AEBBD1C060AE; Fri, 1 Dec 2023 16:38:40 +0000 (UTC) Date: Fri, 1 Dec 2023 17:38:39 +0100 From: Kevin Wolf To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" , David Hildenbrand , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Peter Xu , Paolo Bonzini , Fam Zheng Subject: Re: [PATCH 3/4] scsi: don't lock AioContext in I/O code path Message-ID: References: <20231123194931.171598-1-stefanha@redhat.com> <20231123194931.171598-4-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231123194931.171598-4-stefanha@redhat.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 Received-SPF: pass client-ip=170.10.133.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Am 23.11.2023 um 20:49 hat Stefan Hajnoczi geschrieben: > blk_aio_*() doesn't require the AioContext lock and the SCSI subsystem's > internal state also does not anymore. > > Signed-off-by: Stefan Hajnoczi With this one, I'm not really confident enough to give a R-b. I couldn't find a problem, but I suppose it's more a case of "looks plausible enough, we'll see what breaks". And while scsi is managable enough that I could in theory invest a few more hours, we'll get more changes of the same type anyway when merging the full removal of the AioContext lock and reviewing all of that in detail will be impossible. Acked-by: Kevin Wolf