From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Hyman Huang <yong.huang@smartx.com>
Cc: qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
Hanna Reitz <hreitz@redhat.com>, Eric Blake <eblake@redhat.com>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [v2 0/4] Support generic Luks encryption
Date: Mon, 18 Dec 2023 11:21:07 +0000 [thread overview]
Message-ID: <ZYArI__TwpzTb0xp@redhat.com> (raw)
In-Reply-To: <cover.1701879996.git.yong.huang@smartx.com>
On Thu, Dec 07, 2023 at 12:37:41AM +0800, Hyman Huang wrote:
> v2:
> - Simplify the design by reusing the LUKS driver to implement
> the generic Luks encryption, thank Daniel for the insightful
> advice.
> - rebase on master.
>
> Hyman Huang (4):
> crypto: Introduce option and structure for detached LUKS header
> crypto: Introduce payload offset set function
> crypto: Support generic LUKS encryption
> block: Support detached LUKS header creation for blockdev-create
>
> block/crypto.c | 47 ++++++++++++++++++++++++++++++++++++++++--
> crypto/block.c | 4 ++++
> include/crypto/block.h | 1 +
> qapi/block-core.json | 11 ++++++++--
> 4 files changed, 59 insertions(+), 4 deletions(-)
Could you add a scenario tests/qemu-iotests/tests/luks-detached-header
to provide coverage of this method feature.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2023-12-18 11:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 16:37 [v2 0/4] Support generic Luks encryption Hyman Huang
2023-12-06 16:37 ` [v2 1/4] crypto: Introduce option and structure for detached LUKS header Hyman Huang
2023-12-18 11:16 ` Daniel P. Berrangé
2023-12-06 16:37 ` [v2 2/4] crypto: Introduce payload offset set function Hyman Huang
2023-12-18 11:16 ` Daniel P. Berrangé
2023-12-06 16:37 ` [v2 3/4] crypto: Support generic LUKS encryption Hyman Huang
2023-12-18 11:15 ` Daniel P. Berrangé
2023-12-18 14:15 ` Yong Huang
2023-12-18 14:24 ` Daniel P. Berrangé
2023-12-06 16:37 ` [v2 4/4] block: Support detached LUKS header creation for blockdev-create Hyman Huang
2023-12-18 11:19 ` Daniel P. Berrangé
2023-12-18 14:17 ` Yong Huang
2023-12-18 11:21 ` Daniel P. Berrangé [this message]
2023-12-18 13:22 ` [v2 0/4] Support generic Luks encryption Yong Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZYArI__TwpzTb0xp@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yong.huang@smartx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).