From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 59436C35274 for ; Thu, 21 Dec 2023 06:40:17 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rGCih-0005u7-0j; Thu, 21 Dec 2023 01:39:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rGCie-0005tt-UU; Thu, 21 Dec 2023 01:39:45 -0500 Received: from 60-248-80-70.hinet-ip.hinet.net ([60.248.80.70] helo=Atcsqr.andestech.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rGCib-0004xx-BK; Thu, 21 Dec 2023 01:39:44 -0500 Received: from mail.andestech.com (ATCPCS16.andestech.com [10.0.1.222]) by Atcsqr.andestech.com with ESMTP id 3BL6cjS0092035; Thu, 21 Dec 2023 14:38:45 +0800 (+08) (envelope-from ethan84@andestech.com) Received: from ethan84-VirtualBox (10.0.12.51) by ATCPCS16.andestech.com (10.0.1.222) with Microsoft SMTP Server id 14.3.498.0; Thu, 21 Dec 2023 14:38:43 +0800 Date: Thu, 21 Dec 2023 14:38:27 +0800 To: Alistair Francis CC: , , , , , , , , , , , , , Subject: Re: [PATCH v4 0/4] Support RISC-V IOPMP Message-ID: References: <20231122053251.440723-1-ethan84@andestech.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.1.4 (2021-12-11) X-Originating-IP: [10.0.12.51] X-DNSRBL: X-MAIL: Atcsqr.andestech.com 3BL6cjS0092035 Received-SPF: pass client-ip=60.248.80.70; envelope-from=ethan84@andestech.com; helo=Atcsqr.andestech.com X-Spam_score_int: -8 X-Spam_score: -0.9 X-Spam_bar: / X-Spam_report: (-0.9 / 5.0 requ) BAYES_00=-1.9, RDNS_DYNAMIC=0.982, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, TVD_RCVD_IP=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Ethan Chen From: Ethan Chen via Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, Dec 18, 2023 at 02:18:58PM +1000, Alistair Francis wrote: > On Wed, Nov 22, 2023 at 3:36 PM Ethan Chen via wrote: > > > > This series implements IOPMP specification v1.0.0-draft4 rapid-k model. > > The specification url: > > https://github.com/riscv-non-isa/iopmp-spec/blob/main/riscv_iopmp_specification.pdf > > > > When IOPMP is enabled, a DMA device ATCDMAC300 is added to RISC-V virt > > platform. This DMA device is connected to the IOPMP and has the functionalities > > I don't think we want to add an Andes DMA device to the virt machine. > > I can't even find the spec for the ATCDMAC300, which isn't great > > Alistair Since the IOPMP does not take effect when there is no other device connects to IOPMP, I think it is necessary to have a DMA device for IOPMP demonstration. Do you have any suggestions for supporting IOPMP on RISC-V virt machine? Thanks, Ethan Chen > > > required by IOPMP, including: > > - Support setup the connection to IOPMP > > - Support asynchronous I/O to handle stall transactions > > - Send transaction information > > > > IOPMP takes a transaction which partially match an entry as a partially hit > > error. The transaction size is depending on source device, destination device > > and bus. > > > > Source device can send a transaction_info to IOPMP. IOPMP will check partially > > hit by transaction_info. If source device does not send a transaction_info, > > IOPMP checks information in IOMMU and dose not check partially hit. > > > > Changes for v4: > > > > - Add descriptions of IOPMP and ATCDMAC300 > > - Refine coding style and comments > > - config XILINX_AXI does not include file stream.c but selects config STREAM > > instead. > > - ATCDMAC300: INT_STATUS is write 1 clear per bit > > Rename iopmp_address_sink to transcation_info_sink > > - IOPMP: Refine error message and remove unused variable > > - VIRT: Document new options > > atcdmac300 is only added when iopmp is enabled > > serial setting should not be changed > > > > Ethan Chen (4): > > hw/core: Add config stream > > Add RISC-V IOPMP support > > hw/dma: Add Andes ATCDMAC300 support > > hw/riscv/virt: Add IOPMP support > > > > docs/system/riscv/virt.rst | 11 + > > hw/Kconfig | 1 + > > hw/core/Kconfig | 3 + > > hw/core/meson.build | 2 +- > > hw/dma/Kconfig | 4 + > > hw/dma/atcdmac300.c | 566 ++++++++++ > > hw/dma/meson.build | 1 + > > hw/misc/Kconfig | 4 + > > hw/misc/meson.build | 1 + > > hw/misc/riscv_iopmp.c | 966 ++++++++++++++++++ > > hw/riscv/Kconfig | 2 + > > hw/riscv/virt.c | 65 ++ > > include/hw/dma/atcdmac300.h | 180 ++++ > > include/hw/misc/riscv_iopmp.h | 341 +++++++ > > .../hw/misc/riscv_iopmp_transaction_info.h | 28 + > > include/hw/riscv/virt.h | 10 +- > > 16 files changed, 2183 insertions(+), 2 deletions(-) > > create mode 100644 hw/dma/atcdmac300.c > > create mode 100644 hw/misc/riscv_iopmp.c > > create mode 100644 include/hw/dma/atcdmac300.h > > create mode 100644 include/hw/misc/riscv_iopmp.h > > create mode 100644 include/hw/misc/riscv_iopmp_transaction_info.h > > > > -- > > 2.34.1 > > > >