From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>,
pbonzini@redhat.com, Peter Xu <peterx@redhat.com>,
qemu-block@nongnu.org, Hanna Reitz <hreitz@redhat.com>,
Fabiano Rosas <farosas@suse.de>,
Leonardo Bras <leobras@redhat.com>,
Eric Blake <eblake@redhat.com>, Fam Zheng <fam@euphon.net>
Subject: Re: [PATCH v3 0/6] qemu-iotests fixes for Kevin's block tree
Date: Thu, 21 Dec 2023 22:02:20 +0100 [thread overview]
Message-ID: <ZYSn3EoLhaxKEbdB@redhat.com> (raw)
In-Reply-To: <20231221192452.1785567-1-stefanha@redhat.com>
Am 21.12.2023 um 20:24 hat Stefan Hajnoczi geschrieben:
> v3:
> - Add aio_wait_kick() into nbd_read_eof() to avoid race with nbd_drained_poll()
> [Kevin]
>
> v2:
> - Drop useless if (client->quiesing) check [Kevin]
> - run qio_channel_read_wake() in export AioContext to avoid race [Kevin]
> - Introduce nbd_client_put_nonzero() optimization [Paolo]
> - Reach goto label disconnect with client->lock taken [Paolo]
> - Add doc comment explaining nbd_co_receive_request() loop in nbd_trip() [Kevin]
>
> Kevin merged several of my outstanding multi-queue block layer patch series and
> found that qemu-iotests -qcow2 was broken. This patch series fixes the block branch.
>
> Most of the fixes are easy but the NBD server required deeper debugging and
> thread-safety fixes. The NBD server patches can be inserted before "aio: make
> aio_context_acquire()/aio_context_release() a no-op" to preserve bisectability.
> The other patches are fixups that can be squashed into the original patches.
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2023-12-21 21:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 19:24 [PATCH v3 0/6] qemu-iotests fixes for Kevin's block tree Stefan Hajnoczi
2023-12-21 19:24 ` [PATCH v3 1/6] fixup block-coroutine-wrapper: use qemu_get_current_aio_context() Stefan Hajnoczi
2023-12-21 19:24 ` [PATCH v3 2/6] fixup block: remove AioContext locking Stefan Hajnoczi
2023-12-21 19:24 ` [PATCH v3 3/6] fixup scsi: only access SCSIDevice->requests from one thread Stefan Hajnoczi
2023-12-21 19:24 ` [PATCH v3 4/6] nbd/server: avoid per-NBDRequest nbd_client_get/put() Stefan Hajnoczi
2023-12-21 19:24 ` [PATCH v3 5/6] nbd/server: only traverse NBDExport->clients from main loop thread Stefan Hajnoczi
2023-12-21 19:24 ` [PATCH v3 6/6] nbd/server: introduce NBDClient->lock to protect fields Stefan Hajnoczi
2023-12-21 21:02 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZYSn3EoLhaxKEbdB@redhat.com \
--to=kwolf@redhat.com \
--cc=eblake@redhat.com \
--cc=fam@euphon.net \
--cc=farosas@suse.de \
--cc=hreitz@redhat.com \
--cc=leobras@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).