From: Kevin Wolf <kwolf@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH 0/3] block: Make snapshots fail gracefully on inactive images
Date: Tue, 9 Jan 2024 12:01:07 +0100 [thread overview]
Message-ID: <ZZ0nc7Z3T5dU2HaS@redhat.com> (raw)
In-Reply-To: <2b505ab7-f01e-4b02-8bbe-295631027bbf@tls.msk.ru>
Am 22.12.2023 um 20:24 hat Michael Tokarev geschrieben:
> 01.12.2023 17:25, Kevin Wolf :
> > Kevin Wolf (3):
> > block: Fix crash when loading snapshot on inactive node
> > vl: Improve error message for conflicting -incoming and -loadvm
> > iotests: Basic tests for internal snapshots
>
> This smells like a stable-8.2 material, at least the first change
> (tho I'd pick all 3). Maybe stable-8.1 too.
Yes, makes sense to me. It was a bit late for 8.2.0, but adding it to a
future stable release is reasonable.
> On the other hand, this is a rarely-used code path.
It is, but if you do hit it, it's still a crash.
Kevin
prev parent reply other threads:[~2024-01-09 11:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 14:25 [PATCH 0/3] block: Make snapshots fail gracefully on inactive images Kevin Wolf
2023-12-01 14:25 ` [PATCH 1/3] block: Fix crash when loading snapshot on inactive node Kevin Wolf
2023-12-01 14:25 ` [PATCH 2/3] vl: Improve error message for conflicting -incoming and -loadvm Kevin Wolf
2023-12-01 14:25 ` [PATCH 3/3] iotests: Basic tests for internal snapshots Kevin Wolf
2023-12-22 19:24 ` [PATCH 0/3] block: Make snapshots fail gracefully on inactive images Michael Tokarev
2024-01-09 11:01 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZZ0nc7Z3T5dU2HaS@redhat.com \
--to=kwolf@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).