qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Zhao Liu <zhao1.liu@linux.intel.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: Eduardo Habkost <eduardo@habkost.net>,
	Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
	Yanan Wang <wangyanan55@huawei.com>,
	qemu-devel@nongnu.org, Zhao Liu <zhao1.liu@intel.com>
Subject: Re: [PATCH 2/2] hw/cpu/cluster: Cleanup unused included header in cluster.c
Date: Wed, 3 Jan 2024 22:13:19 +0800	[thread overview]
Message-ID: <ZZVrfyl9OgGRw6/O@intel.com> (raw)
In-Reply-To: <605a850b-ebdd-4744-a772-5b20ec171ec7@linaro.org>

On Tue, Nov 28, 2023 at 11:02:00AM +0100, Philippe Mathieu-Daudé wrote:
> Date: Tue, 28 Nov 2023 11:02:00 +0100
> From: Philippe Mathieu-Daudé <philmd@linaro.org>
> Subject: Re: [PATCH 2/2] hw/cpu/cluster: Cleanup unused included header in
>  cluster.c
> 
> On 27/11/23 15:56, Zhao Liu wrote:
> > From: Zhao Liu <zhao1.liu@intel.com>
> > 
> > Remove unused header (qemu/module.h and qemu/cutils.h) in cluster.c,
> > and reorder the remaining header files (except qemu/osdep.h) in
> > alphabetical order.
> > 
> > Tested by "./configure" and then "make".
> > 
> > Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> > ---
> >   hw/cpu/cluster.c | 5 ++---
> >   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>

Thanks Philippe!

BTW, could these two patches be merged into your next tree?

I also find these 2 headers are included in many cases, maybe I can go
further and do a more thorough cleaning.

Regards,
Zhao



      reply	other threads:[~2024-01-03 14:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-27 14:56 [PATCH 0/2] Cleanup unused included header in core.c & cluster.c Zhao Liu
2023-11-27 14:56 ` [PATCH 1/2] hw/cpu/core: Cleanup unused included header in core.c Zhao Liu
2023-11-28 10:00   ` Philippe Mathieu-Daudé
2023-11-27 14:56 ` [PATCH 2/2] hw/cpu/cluster: Cleanup unused included header in cluster.c Zhao Liu
2023-11-28 10:02   ` Philippe Mathieu-Daudé
2024-01-03 14:13     ` Zhao Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZZVrfyl9OgGRw6/O@intel.com \
    --to=zhao1.liu@linux.intel.com \
    --cc=eduardo@habkost.net \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=wangyanan55@huawei.com \
    --cc=zhao1.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).