From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Samuel Tardieu <sam@rfc1149.net>
Cc: qemu-devel@nongnu.org, Konstantin Kostiuk <kkostiuk@redhat.com>,
Michael Roth <michael.roth@amd.com>
Subject: Re: [PATCH] tests/unit/test-qga: do not qualify executable paths
Date: Wed, 3 Jan 2024 17:00:31 +0000 [thread overview]
Message-ID: <ZZWSr8p5HF1-SdFy@redhat.com> (raw)
In-Reply-To: <20240103165131.2166988-1-sam@rfc1149.net>
On Wed, Jan 03, 2024 at 05:51:31PM +0100, Samuel Tardieu wrote:
> guest-exec invocation does not need the full path of the executable to
> execute. Using only the command names ensures correct execution of the
> test on systems not adhering to the FHS.
>
> Signed-off-by: Samuel Tardieu <sam@rfc1149.net>
> ---
> tests/unit/test-qga.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2024-01-03 17:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-03 16:51 [PATCH] tests/unit/test-qga: do not qualify executable paths Samuel Tardieu
2024-01-03 17:00 ` Daniel P. Berrangé [this message]
2024-01-03 17:34 ` Philippe Mathieu-Daudé
2024-01-16 17:24 ` Konstantin Kostiuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZZWSr8p5HF1-SdFy@redhat.com \
--to=berrange@redhat.com \
--cc=kkostiuk@redhat.com \
--cc=michael.roth@amd.com \
--cc=qemu-devel@nongnu.org \
--cc=sam@rfc1149.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).