From: Peter Xu <peterx@redhat.com>
To: Het Gala <het.gala@nutanix.com>
Cc: Fabiano Rosas <farosas@suse.de>,
qemu-devel@nongnu.org, prerna.saxena@nutanix.com,
berrange@redhat.com, peter.maydell@linaro.org, armbru@redhat.com
Subject: Re: [PATCH] migration: Simplify initial conditionals in migration for better readability
Date: Thu, 4 Jan 2024 16:07:42 +0800 [thread overview]
Message-ID: <ZZZnTmVxn4tha1qL@x1n> (raw)
In-Reply-To: <0db9854c-4e4f-4f2a-a143-16d3ca62f44a@nutanix.com>
On Thu, Jan 04, 2024 at 01:13:48PM +0530, Het Gala wrote:
> Ping. In-case this patch has been missed out. Waiting for other maintainers to respond. Thanks!
>
> On 11/12/23 6:43 pm, Het Gala wrote:
> > Ping? Waiting for other maintainers to respond on this patch
> > On 05/12/23 6:28 pm, Fabiano Rosas wrote:
> > > Het Gala<het.gala@nutanix.com> writes:
> > >
> > > > The inital conditional statements in qmp migration functions is harder
> > > > to understand than necessary. It is better to get all errors out of
> > > > the way in the beginning itself to have better readability and error
> > > > handling.
> > > >
> > > > Signed-off-by: Het Gala<het.gala@nutanix.com>
> > > > Suggested-by: Markus Armbruster<armbru@redhat.com>
> > > Reviewed-by: Fabiano Rosas<farosas@suse.de>
> > >
> > Regards,
> > Het Gala
queued in staging. will be in the next pull.
https://gitlab.com/peterx/qemu/-/tree/migration-staging
Thanks,
--
Peter Xu
prev parent reply other threads:[~2024-01-04 8:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 8:00 [PATCH] migration: Simplify initial conditionals in migration for better readability Het Gala
2023-12-05 8:03 ` Het Gala
2023-12-05 12:58 ` Fabiano Rosas
2023-12-11 13:13 ` Het Gala
2024-01-04 7:43 ` Het Gala
2024-01-04 8:07 ` Peter Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZZZnTmVxn4tha1qL@x1n \
--to=peterx@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=farosas@suse.de \
--cc=het.gala@nutanix.com \
--cc=peter.maydell@linaro.org \
--cc=prerna.saxena@nutanix.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).