From: Zhao Liu <zhao1.liu@intel.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, Laurent Vivier <lvivier@redhat.com>,
Thomas Huth <thuth@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] qtest: use correct boolean type for failover property
Date: Fri, 5 Jan 2024 00:37:14 +0800 [thread overview]
Message-ID: <ZZbeuu8pOtAXw6iR@intel.com> (raw)
In-Reply-To: <20240103123005.2400437-1-berrange@redhat.com>
On Wed, Jan 03, 2024 at 12:30:05PM +0000, Daniel P. Berrangé wrote:
> Date: Wed, 3 Jan 2024 12:30:05 +0000
> From: "Daniel P. Berrangé" <berrange@redhat.com>
> Subject: [PATCH] qtest: use correct boolean type for failover property
>
> QMP device_add does not historically validate the parameter types.
> At some point it will likely change to enforce correct types, to
> match behaviour of -device. The failover property is expected to
> be a boolean in JSON.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> tests/qtest/virtio-net-failover.c | 36 +++++++++++++++----------------
> 1 file changed, 18 insertions(+), 18 deletions(-)
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
prev parent reply other threads:[~2024-01-04 16:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-03 12:30 [PATCH] qtest: use correct boolean type for failover property Daniel P. Berrangé
2024-01-04 16:37 ` Zhao Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZZbeuu8pOtAXw6iR@intel.com \
--to=zhao1.liu@intel.com \
--cc=berrange@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).