From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A8F14C3DA6E for ; Fri, 5 Jan 2024 18:07:47 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rLobb-0001oZ-QT; Fri, 05 Jan 2024 13:07:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rLobZ-0001ne-D2 for qemu-devel@nongnu.org; Fri, 05 Jan 2024 13:07:37 -0500 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rLobX-0004S1-HE for qemu-devel@nongnu.org; Fri, 05 Jan 2024 13:07:37 -0500 Received: by mail-pj1-x1031.google.com with SMTP id 98e67ed59e1d1-28b6218d102so1440547a91.0 for ; Fri, 05 Jan 2024 10:07:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1704478054; x=1705082854; darn=nongnu.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=bHsHpKSLxo23gNzK+/R47h+VsUNDD5UAjZsR9YYsCiA=; b=BXbLHYVaPjnMIf5nGCNo3l1i/QEDOJZPLdd2bmiP4iYHaC1FzNe0QHz4LgMLjS+PXC KPCQynwdzvku7JcPtKoxf6xwomQlyTJ7XD1LLJQhN3WLebz4Tl0w1VZGQCdf+qa3TI2N VzxNd3Ps8T0zkYs/hKolP8DNZy/XUHlA+RdWYb1TYbs9el9jgmhNqtwhVn1a9iVSsAjZ dPB5umfYqo1traiQzrsYlZx+Kr9qkcQuEiNd6tshdXtSsA2syHlHwrvE0bCfH29GPTDR 7ZaWIHsRCnHBTrxmHIhJSQPwkNLYE0ymPxWXpP3LUfFXZ0wY33E8JWPlgidmQlMA9e/H 812Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704478054; x=1705082854; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bHsHpKSLxo23gNzK+/R47h+VsUNDD5UAjZsR9YYsCiA=; b=ix4TwqULZJTdmU/6jUcRN4n/+ryVLv+BB9yjJn7i1BGEuYzzWsLXkLa4X6X+N1QwQa /gb11u5DjkNFe/b5WE7rYDI932poKqLZ5apniVzCyX8CYgrk5EenOPSfXxkcMCN7Y6zy gj6Pp/WxBABm/j509BqMZ/B/DkOrCyYikXWif/DOiFNkJ6k7ke/feB4Sewn7geCD98WT LTPWD5KnQbxlY8bcNdJgiHjDtR2Bk3Jb962mHt0ZJ0R96eigJ+KkFW/MZHheuil5p8HI d/xIHT8CWGaGfxaSlBCSm35oBvCVuY5xo5tRQjP5HA9cdwTJ9fHMWY3JP7/w9ZIuZD5y 3ybQ== X-Gm-Message-State: AOJu0Ywaww4BAjANr/I7AUoTaZpSi+hCsvt6rSoH0TsLT8Kl2Do/jjz7 v9st70k4FaLJQ8jnjVsU+QTqXa4Ia9zFL+4Uk+DaKsvU7do= X-Google-Smtp-Source: AGHT+IHB5+gHzlK/cEboxvuzNU4lb6gZ89r1I1YTI4BPHCim+HQdiFgvSLABzWLzcHuADwhUMYME0Q== X-Received: by 2002:a17:90a:4f05:b0:28b:ecdf:326f with SMTP id p5-20020a17090a4f0500b0028becdf326fmr2192448pjh.87.1704478053983; Fri, 05 Jan 2024 10:07:33 -0800 (PST) Received: from debug.ba.rivosinc.com ([64.71.180.162]) by smtp.gmail.com with ESMTPSA id sb6-20020a17090b50c600b0028d2500e82esm23775pjb.50.2024.01.05.10.07.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jan 2024 10:07:33 -0800 (PST) Date: Fri, 5 Jan 2024 10:07:32 -0800 From: Deepak Gupta To: Alexey Baturo Cc: richard.henderson@linaro.org, zhiwei_liu@linux.alibaba.com, palmer@dabbelt.com, Alistair.Francis@wdc.com, sagark@eecs.berkeley.edu, kbastian@mail.uni-paderborn.de, qemu-devel@nongnu.org, qemu-riscv@nongnu.org Subject: Re: [PATCH v3 5/6] target/riscv: Update address modify functions to take into account pointer masking Message-ID: References: <20240103185716.1790546-1-me@deliversmonkey.space> <20240103185716.1790546-6-me@deliversmonkey.space> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::1031; envelope-from=debug@rivosinc.com; helo=mail-pj1-x1031.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, Jan 05, 2024 at 10:29:35AM +0300, Alexey Baturo wrote: >> + addr = addr << pmlen; >> + if (signext) { >> + addr = (target_long)addr >> pmlen; >> + } else { >> + addr = addr >> pmlen; >Could you please elaborate a bit more on your concern here? >I believe this code works as intended: https://godbolt.org/z/b9c7na13a Nevermind I missed this above in code. addr = addr << pmlen; You're good. Sorry about that. > >Thanks > >пт, 5 янв. 2024 г. в 04:02, Deepak Gupta : > >> > --- a/target/riscv/vector_helper.c >> > +++ b/target/riscv/vector_helper.c >> > @@ -94,6 +94,18 @@ static inline uint32_t vext_max_elems(uint32_t desc, >> uint32_t log2_esz) >> > >> > static inline target_ulong adjust_addr(CPURISCVState *env, target_ulong >> addr) >> > { >> > + RISCVPmPmm pmm = riscv_pm_get_pmm(env); >> > + if (pmm == PMM_FIELD_DISABLED) >> > + return addr; >> > + int pmlen = riscv_pm_get_pmlen(pmm); >> > + bool signext = !riscv_cpu_bare_mode(env); >> > + addr = addr << pmlen; >> > + /* sign/zero extend masked address by N-1 bit */ >> > + if (signext) { >> > + addr = (target_long)addr >> pmlen; >> >> These look like right shift operations and not sign extensions of N-1 bit >> >> > + } else { >> > + addr = addr >> pmlen; >> >> Same here. >> >> > + } >> > return addr; >> > } >> > >> > -- >> > 2.34.1 >> > >> > >>