From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B21F8C47079 for ; Mon, 8 Jan 2024 14:44:49 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rMqrc-0006rF-VV; Mon, 08 Jan 2024 09:44:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rMqrb-0006r0-3I for qemu-devel@nongnu.org; Mon, 08 Jan 2024 09:44:27 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rMqrZ-0003Fo-3c for qemu-devel@nongnu.org; Mon, 08 Jan 2024 09:44:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704725063; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jv+eiYFKWIvKB/NA82payv2oFkXWk5n2COx/m/9slT4=; b=STZ2noGZsWU6M/26CrE2peiA0xg3iKw/f8FG0OuE2/moGdn1Lvt6zYOImRB0fnt+6rStjX EovHmA6L1ggmCwTSq/8+sr2Sq2eBYZKHII63scv5xP8XBBwbOJH7t6yjW2B3TzSW2LG7Ln TyDpbxYE07s/E/mzEdaMNrcij1nNEq4= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-558-RfIQ38MkNqaRWDG8T6W6Bg-1; Mon, 08 Jan 2024 09:44:20 -0500 X-MC-Unique: RfIQ38MkNqaRWDG8T6W6Bg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 898CD1C05132; Mon, 8 Jan 2024 14:44:19 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.90]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 014BA2166B35; Mon, 8 Jan 2024 14:44:14 +0000 (UTC) Date: Mon, 8 Jan 2024 14:44:12 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Xiaoyao Li Cc: Paolo Bonzini , David Hildenbrand , Igor Mammedov , "Michael S . Tsirkin" , Marcel Apfelbaum , Richard Henderson , Peter Xu , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Cornelia Huck , Eric Blake , Markus Armbruster , Marcelo Tosatti , qemu-devel@nongnu.org, kvm@vger.kernel.org, Michael Roth , Sean Christopherson , Claudio Fontana , Gerd Hoffmann , Isaku Yamahata , Chenyi Qiang Subject: Re: [PATCH v3 52/70] i386/tdx: handle TDG.VP.VMCALL Message-ID: References: <20231115071519.2864957-1-xiaoyao.li@intel.com> <20231115071519.2864957-53-xiaoyao.li@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.2.10 (2023-03-25) X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-2.243, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, Dec 29, 2023 at 10:30:15AM +0800, Xiaoyao Li wrote: > On 11/16/2023 1:58 AM, Daniel P. Berrangé wrote: > > On Wed, Nov 15, 2023 at 02:15:01AM -0500, Xiaoyao Li wrote: > > > From: Isaku Yamahata > > > > > > For GetQuote, delegate a request to Quote Generation Service. > > > Add property "quote-generation-socket" to tdx-guest, whihc is a property > > > of type SocketAddress to specify Quote Generation Service(QGS). > > > > > > On request, connect to the QGS, read request buffer from shared guest > > > memory, send the request buffer to the server and store the response > > > into shared guest memory and notify TD guest by interrupt. > > > > > > command line example: > > > qemu-system-x86_64 \ > > > -object '{"qom-type":"tdx-guest","id":"tdx0","quote-generation-socket":{"type": "vsock", "cid":"2","port":"1234"}}' \ > > > -machine confidential-guest-support=tdx0 > > > > > > Signed-off-by: Isaku Yamahata > > > Codeveloped-by: Chenyi Qiang > > > Signed-off-by: Chenyi Qiang > > > Signed-off-by: Xiaoyao Li > > > --- > > > Changes in v3: > > > - rename property "quote-generation-service" to "quote-generation-socket"; > > > - change the type of "quote-generation-socket" from str to > > > SocketAddress; > > > - squash next patch into this one; > > > --- > > > qapi/qom.json | 5 +- > > > target/i386/kvm/tdx.c | 430 ++++++++++++++++++++++++++++++++++++++++++ > > > target/i386/kvm/tdx.h | 6 + > > > 3 files changed, 440 insertions(+), 1 deletion(-) > > > > > > +static void tdx_handle_get_quote_connected(QIOTask *task, gpointer opaque) > > > +{ > > > + struct tdx_get_quote_task *t = opaque; > > > + Error *err = NULL; > > > + char *in_data = NULL; > > > + MachineState *ms; > > > + TdxGuest *tdx; > > > + > > > + t->hdr.error_code = cpu_to_le64(TDX_VP_GET_QUOTE_ERROR); > > > + if (qio_task_propagate_error(task, NULL)) { > > > + t->hdr.error_code = cpu_to_le64(TDX_VP_GET_QUOTE_QGS_UNAVAILABLE); > > > + goto error; > > > + } > > > + > > > + in_data = g_malloc(le32_to_cpu(t->hdr.in_len)); > > > + if (!in_data) { > > > + goto error; > > > + } > > > + > > > + if (address_space_read(&address_space_memory, t->gpa + sizeof(t->hdr), > > > + MEMTXATTRS_UNSPECIFIED, in_data, > > > + le32_to_cpu(t->hdr.in_len)) != MEMTX_OK) { > > > + goto error; > > > + } > > > + > > > + qio_channel_set_blocking(QIO_CHANNEL(t->ioc), false, NULL); > > > > You've set the channel to non-blocking, but.... > > > > > + > > > + if (qio_channel_write_all(QIO_CHANNEL(t->ioc), in_data, > > > + le32_to_cpu(t->hdr.in_len), &err) || > > > + err) { > > > > ...this method will block execution of this thread, by either > > sleeping in poll() or doing a coroutine yield. > > > > I don't think this is in coroutine context, so presumably this > > is just blocking. So what was the point in marking the channel > > non-blocking ? > > Hi Dainel, > > First of all, I'm not good at socket or qio channel thing. Please correct me > and teach me when I'm wrong. > > I'm not the author of this patch. My understanding is that, set it to > non-blocking is for the qio_channel_write_all() to proceed immediately? The '_all' suffixed methods are implemented such that they will sleep in poll(), or a coroutine yield when seeing EAGAIN. > If set non-blocking is not needed, I can remove it. > > > You are setting up a background watch to wait for the reply > > so we don't block this thread, so you seem to want non-blocking > > behaviour. > > Both sending and receiving are in a new thread created by > qio_channel_socket_connect_async(). So I think both of then can be blocking > and don't need to be in another background thread. > > what's your suggestion on it? Make both sending and receiving blocking or > non-blocking? I think the code /should/ be non-blocking, which would mean using qio_channel_write, instead of qio_channel_write_all, and using a . With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|