From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BDE36C369B5 for ; Tue, 15 Apr 2025 09:21:54 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u4cTa-0004tN-LY; Tue, 15 Apr 2025 05:21:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u4cTY-0004t5-O7 for qemu-devel@nongnu.org; Tue, 15 Apr 2025 05:21:05 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u4cTU-0001gD-Ca for qemu-devel@nongnu.org; Tue, 15 Apr 2025 05:21:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744708857; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=dZdv930jsEKqkYB09Bg+I9u1m1PgebQQTjspeQRqxnw=; b=YJAHhjm9i5m8nUDy0i4EZm00V3tb5u1+5KAjpzV813n5km+qfFz4MI2GDTOXE70rhfLfLQ xMWG8hQ/r8TGz5N/Fg9Ujidz02VdQxDizwFvf3ZGOQ+uaJp3Q5NtS2oTRT2wgNQWZMgrso kOf4KtcI+ntj1DKlvZOq+9ZtLlBfW94= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-465-vPud49jlP1u0tjhbYe-J6g-1; Tue, 15 Apr 2025 05:20:53 -0400 X-MC-Unique: vPud49jlP1u0tjhbYe-J6g-1 X-Mimecast-MFC-AGG-ID: vPud49jlP1u0tjhbYe-J6g_1744708852 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9113C18004A9; Tue, 15 Apr 2025 09:20:51 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.133]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9D9161956054; Tue, 15 Apr 2025 09:20:48 +0000 (UTC) Date: Tue, 15 Apr 2025 10:20:44 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Alexandr Moshkov Cc: qemu-devel@nongnu.org, Cleber Rosa , "yc-core @ yandex-team . ru" , Paolo Bonzini Subject: Re: [PATCH v3] tests/functional: add memlock tests Message-ID: References: <20250415090854.71526-1-dtalexundeer@yandex-team.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250415090854.71526-1-dtalexundeer@yandex-team.ru> User-Agent: Mutt/2.2.13 (2024-03-09) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Apr 15, 2025 at 02:08:55PM +0500, Alexandr Moshkov wrote: > Add new tests to check the correctness of the `-overcommit memlock` > option (possible values: off, on, on-fault) by using > `/proc/{qemu_pid}/smaps` file to check in Size, Rss and Locked fields of > anonymous segments: > > * if `memlock=off`, then Locked = 0 on every anonymous smaps; > * if `memlock=on`, then Size, Rss and Locked values must be equal for > every anon smaps where Rss is not 0; > * if `memlock=on-fault`, then Rss and Locked must be equal on every anon > smaps and anonymous segment with Rss < Size must exists. How are you running this test ? Unprivileged users don't get to lock any non-trivial amount of memory by default, and QEMU functional tests pretty much exclusively get run as an unprivileged user account. This test immediately fails when run: qemu.machine.machine.VMLaunchFailure: ConnectError: Failed to establish session: EOFError Exit code: 1 Command: ./build/qemu-system-x86_64 -display none -vga none -chardev socket,id=mon,fd=5 -mon chardev=mon,mode=control -overcommit mem-lock=on Output: qemu-system-x86_64: mlockall: Cannot allocate memory qemu-system-x86_64: locking memory failed and we don't expect users to run anything as root. > Signed-off-by: Alexandr Moshkov > --- > tests/functional/meson.build | 1 + > tests/functional/test_memlock.py | 100 +++++++++++++++++++++++++++++++ > 2 files changed, 101 insertions(+) > create mode 100644 tests/functional/test_memlock.py Test files need to have execute permission set. > With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|