From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2CD41C47077 for ; Tue, 16 Jan 2024 14:07:12 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rPk5a-0003B3-1U; Tue, 16 Jan 2024 09:06:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rPk5R-00035Y-EJ for qemu-devel@nongnu.org; Tue, 16 Jan 2024 09:06:42 -0500 Received: from mgamail.intel.com ([198.175.65.9]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rPk5N-0006Ct-MP for qemu-devel@nongnu.org; Tue, 16 Jan 2024 09:06:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1705413998; x=1736949998; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=cOKapuMNF8YYvoqQUHwf7DhaL2utblqyE3nnXw/+ZCI=; b=iQNmU5mrmyyd5lnM9jgryfe8tt9cwgJBcSuF66JWsxQL+LQxvqlniwHO UbUo3KBReoIRM4W9YdHML2YeKElrH9wa85sjhaJEVNJUu14Dfz/g6urWZ juHmx0HfAPffDMGcWq2M8RLQ2Qm53r6ZOT9owyQPk3a/j3XE24laNTTGD M44gncQblHRPkFDmhpthpxdjdhuEczYRgfwcBDGPuTNHV3Cuj8uMDiV/Q P/Sjzzy7YixfMOoaJassvHeHOTr5jHJRQxc8W5uMKlfpXqUFC0FdnZAyE iXOb12qRXgMeU5+Wf8jK8Q/LmJH/t71XHAR12B5zPkhZB2WTscXYHglnk A==; X-IronPort-AV: E=McAfee;i="6600,9927,10954"; a="18468224" X-IronPort-AV: E=Sophos;i="6.05,199,1701158400"; d="scan'208";a="18468224" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jan 2024 06:06:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10954"; a="733620983" X-IronPort-AV: E=Sophos;i="6.05,199,1701158400"; d="scan'208";a="733620983" Received: from liuzhao-optiplex-7080.sh.intel.com (HELO localhost) ([10.239.160.36]) by orsmga003.jf.intel.com with ESMTP; 16 Jan 2024 06:06:33 -0800 Date: Tue, 16 Jan 2024 22:19:31 +0800 From: Zhao Liu To: Xiaoyao Li Cc: Paolo Bonzini , qemu-devel@nongnu.org, Yang Weijiang Subject: Re: [PATCH 0/2] i386/cpu: Two minor fixes for x86_cpu_enable_xsave_components() Message-ID: References: <20240115091325.1904229-1-xiaoyao.li@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240115091325.1904229-1-xiaoyao.li@intel.com> Received-SPF: pass client-ip=198.175.65.9; envelope-from=zhao1.liu@intel.com; helo=mgamail.intel.com X-Spam_score_int: -38 X-Spam_score: -3.9 X-Spam_bar: --- X-Spam_report: (-3.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.806, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Hi Xiaoyao, On Mon, Jan 15, 2024 at 04:13:23AM -0500, Xiaoyao Li wrote: > Date: Mon, 15 Jan 2024 04:13:23 -0500 > From: Xiaoyao Li > Subject: [PATCH 0/2] i386/cpu: Two minor fixes for > x86_cpu_enable_xsave_components() > X-Mailer: git-send-email 2.34.1 > > The two bugs were introduced when xsaves feature was added by commit > 301e90675c3f ("target/i386: Enable support for XSAVES based features"). Could you please provide more details about reproducing these two bugs? If I'm able, I'd be glad to help you to test and verify them. Regards, Zhao > > Xiaoyao Li (2): > i386/cpu: Clear FEAT_XSAVE_XSS_LO/HI leafs when CPUID_EXT_XSAVE is not > available > i386/cpu: Mask with XCR0/XSS mask for FEAT_XSAVE_XCR0_HI and > FEAT_XSAVE_XSS_HI leafs > > target/i386/cpu.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > -- > 2.34.1 > >