qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: Fabiano Rosas <farosas@suse.de>
Cc: qemu-devel@nongnu.org,
	"Daniel P . Berrangé" <berrange@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Thomas Huth" <thuth@redhat.com>
Subject: Re: [PATCH v4 0/3] migration & CI: Add a CI job for migration compat testing
Date: Fri, 19 Jan 2024 17:11:30 +0800	[thread overview]
Message-ID: <Zao8whp3WCWOPb-9@x1n> (raw)
In-Reply-To: <20240118164951.30350-1-farosas@suse.de>

Fabiano,

On Thu, Jan 18, 2024 at 01:49:48PM -0300, Fabiano Rosas wrote:
> Here's the second half of adding a migration compatibility test to CI.
> 
> We've already added support for running the full set of migration
> tests with two QEMU binaries since commit 5050ad2a380
> ("tests/qtest/migration: Support more than one QEMU binary"), now
> what's left is adding it to the CI.
> 
> changes since v3:
> 
> - Removed all the 'since' logic and started using the n-1 version of
>   the tests.
> 
> - New patch to fix the aarch64 cpu. We shouldn't have been using
>   'max'.
> 
> - New patch to disable aarch64 tests while the fix^ doesn't reach a
>   released version.
> 
> v3:
> https://lore.kernel.org/r/20240105180449.11562-1-farosas@suse.de
> v2:
> https://lore.kernel.org/r/20240104171857.20108-1-farosas@suse.de
> v1:
> https://lore.kernel.org/r/20231207155809.25673-1-farosas@suse.de

I gave it a try but build-previous-qemu somehow failed..

  https://gitlab.com/peterx/qemu/-/jobs/5965634871

You normally attach a "CI run" which I wanted to reference, but it's gone
in this v4 unfortunately.  The error:

  error: pathspec 'v8.2.0' did not match any file(s) known to git

is pretty weird, and I had a feeling it was something wrong before that.
Maybe it's because I tried to run this specific test multiple times (and
all failed), somehow the wrong thing was cached, so the real error (of the
1st run when there is no cache) could have got lost.  Not sure.

Please have a look when you have time, thanks.

> 
> Fabiano Rosas (3):
>   tests/qtest/migration: Don't use -cpu max for aarch64
>   ci: Add a migration compatibility test job
>   ci: Disable migration compatibility tests for aarch64
> 
>  .gitlab-ci.d/buildtest.yml   | 64 ++++++++++++++++++++++++++++++++++++
>  tests/qtest/migration-test.c |  2 +-
>  2 files changed, 65 insertions(+), 1 deletion(-)
> 
> -- 
> 2.35.3
> 

-- 
Peter Xu



  parent reply	other threads:[~2024-01-19  9:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-18 16:49 [PATCH v4 0/3] migration & CI: Add a CI job for migration compat testing Fabiano Rosas
2024-01-18 16:49 ` [PATCH v4 1/3] tests/qtest/migration: Don't use -cpu max for aarch64 Fabiano Rosas
2024-01-18 16:49 ` [PATCH v4 2/3] ci: Add a migration compatibility test job Fabiano Rosas
2024-01-18 16:49 ` [PATCH v4 3/3] ci: Disable migration compatibility tests for aarch64 Fabiano Rosas
2024-01-19  4:01   ` Peter Xu
2024-01-19 13:04     ` Fabiano Rosas
2024-01-20  2:35       ` Peter Xu
2024-01-19  9:11 ` Peter Xu [this message]
2024-01-19 13:01   ` [PATCH v4 0/3] migration & CI: Add a CI job for migration compat testing Fabiano Rosas
2024-01-22 10:23     ` Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zao8whp3WCWOPb-9@x1n \
    --to=peterx@redhat.com \
    --cc=berrange@redhat.com \
    --cc=farosas@suse.de \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).