From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-devel@nongnu.org, "Thomas Huth" <thuth@redhat.com>,
"Hanna Reitz" <hreitz@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
qemu-block@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH 0/6] virtio-blk: iothread-vq-mapping cleanups
Date: Fri, 19 Jan 2024 18:17:12 +0100 [thread overview]
Message-ID: <ZaqumG_cpdSprI1U@redhat.com> (raw)
In-Reply-To: <20240119135748.270944-1-stefanha@redhat.com>
Am 19.01.2024 um 14:57 hat Stefan Hajnoczi geschrieben:
> Kevin Wolf identified some issues with the virtio-blk iothread-vq-mapping patch
> series that was merged at the end of 2023:
> 1. s->rq is restarted from one AioContext and races with the other
> iothread-vq-mapping AioContexts.
> 2. Failure to set the AioContext is no longer fatal since the IO_CODE APIs can
> be called from any thread. We can relax the error handling behavior.
> 3. Starting dataplane must self-trigger the ioeventfd even in a drained
> section. Failure to do so could lead to an unresponsive virtio-blk device.
>
> This patch series addresses these issues. The first few patches merge the
> hw/block/dataplane/virtio-blk.c code into hw/block/virtio-blk.c so that s->rq
> can easily be restarted in the correct AioContexts.
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2024-01-19 17:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-19 13:57 [PATCH 0/6] virtio-blk: iothread-vq-mapping cleanups Stefan Hajnoczi
2024-01-19 13:57 ` [PATCH 1/6] virtio-blk: move dataplane code into virtio-blk.c Stefan Hajnoczi
2024-01-19 13:57 ` [PATCH 2/6] virtio-blk: rename dataplane create/destroy functions Stefan Hajnoczi
2024-01-19 13:57 ` [PATCH 3/6] virtio-blk: rename dataplane to ioeventfd Stefan Hajnoczi
2024-01-19 13:57 ` [PATCH 4/6] virtio-blk: restart s->rq reqs in vq AioContexts Stefan Hajnoczi
2024-01-19 13:57 ` [PATCH 5/6] virtio-blk: tolerate failure to set BlockBackend AioContext Stefan Hajnoczi
2024-01-19 13:57 ` [PATCH 6/6] virtio-blk: always set ioeventfd during startup Stefan Hajnoczi
2024-01-19 17:17 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZaqumG_cpdSprI1U@redhat.com \
--to=kwolf@redhat.com \
--cc=berrange@redhat.com \
--cc=hreitz@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).