From: Peter Xu <peterx@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Markus Armbruster <armbru@redhat.com>,
qemu-devel@nongnu.org, farosas@suse.de, het.gala@nutanix.com
Subject: Re: [PATCH] migration: Plug memory leak on HMP migrate error path
Date: Wed, 24 Jan 2024 09:36:37 +0800 [thread overview]
Message-ID: <ZbBppQ_4sfyYgl4n@x1n> (raw)
In-Reply-To: <CAFEAcA-tX=GPm1zDq5pnL+T_cbivKUQ1dZe_vQ0XAjvehWLdpQ@mail.gmail.com>
On Tue, Jan 23, 2024 at 04:33:43PM +0000, Peter Maydell wrote:
> On Wed, 17 Jan 2024 at 19:49, Markus Armbruster <armbru@redhat.com> wrote:
> >
> > hmp_migrate() leaks @caps when qmp_migrate() fails. Plug the leak
> > with g_autoptr().
> >
> > Fixes: 967f2de5c9ec (migration: Implement MigrateChannelList to hmp migration flow.) v8.2.0-rc0
> > Fixes: CID 1533124
>
> Isn't this 1533125 ? 1533124 is a false positive in
> the migrate_mode() function.
Indeed.. I fixed it in the staging branch (which will be in the final
pull), thanks.
https://gitlab.com/peterx/qemu/-/commit/74278c11b980429916116baf0f742357af51ebb4
--
Peter Xu
next prev parent reply other threads:[~2024-01-24 1:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-17 14:07 [PATCH] migration: Plug memory leak on HMP migrate error path Markus Armbruster
2024-01-18 6:58 ` Peter Xu
2024-01-23 16:33 ` Peter Maydell
2024-01-24 1:36 ` Peter Xu [this message]
2024-01-24 6:47 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbBppQ_4sfyYgl4n@x1n \
--to=peterx@redhat.com \
--cc=armbru@redhat.com \
--cc=farosas@suse.de \
--cc=het.gala@nutanix.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).