From: Kevin Wolf <kwolf@redhat.com>
To: Saif Abrar <saif.abrar@linux.vnet.ibm.com>
Cc: qemu-block@nongnu.org, hreitz@redhat.com, qemu-devel@nongnu.org,
npiggin@gmail.com
Subject: Re: [PATCH] tests/qemu-iotests: Bump timeout of iothreads-stream test
Date: Thu, 25 Jan 2024 17:49:58 +0100 [thread overview]
Message-ID: <ZbKRNj6qUSLkINho@redhat.com> (raw)
In-Reply-To: <20240124133538.2784097-1-saif.abrar@linux.vnet.ibm.com>
Am 24.01.2024 um 14:35 hat Saif Abrar geschrieben:
> Current value of timeout=0.1 is sometimes too tight.
> Bump timeout to 0.3 to avoid test failures.
>
> Signed-off-by: Saif Abrar <saif.abrar@linux.vnet.ibm.com>
This is not the real problem. The real problem is that the timeout makes
the test fail because we're catching the wrong TimeoutError class. What
it really should do is issue another query-jobs and go back to waiting.
I actually sent a patch earlier today to fix this:
https://lists.gnu.org/archive/html/qemu-block/2024-01/msg00353.html
Kevin
prev parent reply other threads:[~2024-01-25 16:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 13:35 [PATCH] tests/qemu-iotests: Bump timeout of iothreads-stream test Saif Abrar
2024-01-25 16:49 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbKRNj6qUSLkINho@redhat.com \
--to=kwolf@redhat.com \
--cc=hreitz@redhat.com \
--cc=npiggin@gmail.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=saif.abrar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).